Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2614663005:
Enable USB device permission for interface class for stable (Closed)
DescriptionEnable USB device permission for interface class for stable
BUG=629223
Review-Url: https://codereview.chromium.org/2614663005
Cr-Commit-Position: refs/heads/master@{#443504}
Committed: https://chromium.googlesource.com/chromium/src/+/aea9d3950199ed22d60da79e6bd5b72c106f5775
Patch Set 1 #Patch Set 2 : documentation #Patch Set 3 : . #Patch Set 4 : . #
Total comments: 10
Patch Set 5 : . #
Total comments: 2
Patch Set 6 : . #
Messages
Total messages: 21 (7 generated)
tbarzic@chromium.org changed reviewers: + reillyg@chromium.org
reillyg@chromium.org changed reviewers: + rdevlin.cronin@chromium.org
Devlin should approve this as Apps/Extensions API owner.
Do we have any documentation for this?
On 2017/01/06 20:47:34, Devlin wrote: > Do we have any documentation for this? Public one? Not yet - I planned to add something to https://developer.chrome.com/apps/app_usb next week.
On 2017/01/06 20:56:42, tbarzic wrote: > On 2017/01/06 20:47:34, Devlin wrote: > > Do we have any documentation for this? > > Public one? Not yet - I planned to add something to > https://developer.chrome.com/apps/app_usb next week. I'd prefer we land documentation in parallel with capability (since this is basically just flipping the switch, and is already implemented on dev). Does that work for you?
On 2017/01/06 21:03:40, Devlin wrote: > On 2017/01/06 20:56:42, tbarzic wrote: > > On 2017/01/06 20:47:34, Devlin wrote: > > > Do we have any documentation for this? > > > > Public one? Not yet - I planned to add something to > > https://developer.chrome.com/apps/app_usb next week. > > I'd prefer we land documentation in parallel with capability (since this is > basically just flipping the switch, and is already implemented on dev). Does > that work for you? Sure, that is fine with me.. I'll ping the CL once I have documentation ready..
Added few paragraphs to the documentation.
rdevlin.cronin@chromium.org changed reviewers: + mkearney@chromium.org
A couple grammar nits (since this is public documentation, we have to be sticklers :)). I'll have to take another look once I'm in the office to see how this looks with preview.py. +Meggin - can you give the docs a once-over if you have a few spare minutes and see if everything looks mostly good? https://codereview.chromium.org/2614663005/diff/60001/chrome/common/extension... File chrome/common/extensions/docs/templates/articles/app_usb.html (right): https://codereview.chromium.org/2614663005/diff/60001/chrome/common/extension... chrome/common/extensions/docs/templates/articles/app_usb.html:64: <p>Since <b>Chrome 57</b>, requirement for declaring all the device types *the* requirement https://codereview.chromium.org/2614663005/diff/60001/chrome/common/extension... chrome/common/extensions/docs/templates/articles/app_usb.html:67: For kiosk apps, you can use <code>interfaceClass</code> permission property to *the* <code>interfaceClass.... https://codereview.chromium.org/2614663005/diff/60001/chrome/common/extension... chrome/common/extensions/docs/templates/articles/app_usb.html:68: declare permission to access USB devices that: s/declare/request? https://codereview.chromium.org/2614663005/diff/60001/chrome/common/extension... chrome/common/extensions/docs/templates/articles/app_usb.html:88: <p>For list of acceptable <code>interfaceClass</code> values, see *the* list https://codereview.chromium.org/2614663005/diff/60001/chrome/common/extension... chrome/common/extensions/docs/templates/articles/app_usb.html:111: in kiosk session - outside a kiosk session said permissions will be ignored. s/said/these
A couple grammar nits (since this is public documentation, we have to be sticklers :)). I'll have to take another look once I'm in the office to see how this looks with preview.py. +Meggin - can you give the docs a once-over if you have a few spare minutes and see if everything looks mostly good?
https://codereview.chromium.org/2614663005/diff/60001/chrome/common/extension... File chrome/common/extensions/docs/templates/articles/app_usb.html (right): https://codereview.chromium.org/2614663005/diff/60001/chrome/common/extension... chrome/common/extensions/docs/templates/articles/app_usb.html:64: <p>Since <b>Chrome 57</b>, requirement for declaring all the device types On 2017/01/10 15:56:50, Devlin wrote: > *the* requirement Done. https://codereview.chromium.org/2614663005/diff/60001/chrome/common/extension... chrome/common/extensions/docs/templates/articles/app_usb.html:67: For kiosk apps, you can use <code>interfaceClass</code> permission property to On 2017/01/10 15:56:50, Devlin wrote: > *the* <code>interfaceClass.... Done. https://codereview.chromium.org/2614663005/diff/60001/chrome/common/extension... chrome/common/extensions/docs/templates/articles/app_usb.html:68: declare permission to access USB devices that: On 2017/01/10 15:56:50, Devlin wrote: > s/declare/request? Done. https://codereview.chromium.org/2614663005/diff/60001/chrome/common/extension... chrome/common/extensions/docs/templates/articles/app_usb.html:88: <p>For list of acceptable <code>interfaceClass</code> values, see On 2017/01/10 15:56:50, Devlin wrote: > *the* list Done. https://codereview.chromium.org/2614663005/diff/60001/chrome/common/extension... chrome/common/extensions/docs/templates/articles/app_usb.html:111: in kiosk session - outside a kiosk session said permissions will be ignored. On 2017/01/10 15:56:50, Devlin wrote: > s/said/these Done.
lgtm https://codereview.chromium.org/2614663005/diff/80001/chrome/common/extension... File chrome/common/extensions/docs/templates/articles/app_usb.html (right): https://codereview.chromium.org/2614663005/diff/80001/chrome/common/extension... chrome/common/extensions/docs/templates/articles/app_usb.html:92: <p><code>interfaceClass</code> property can be combined with nit: missing articles. *The* interfaceClass property can be combined with *the* vendorId property
https://codereview.chromium.org/2614663005/diff/80001/chrome/common/extension... File chrome/common/extensions/docs/templates/articles/app_usb.html (right): https://codereview.chromium.org/2614663005/diff/80001/chrome/common/extension... chrome/common/extensions/docs/templates/articles/app_usb.html:92: <p><code>interfaceClass</code> property can be combined with On 2017/01/12 21:47:20, Devlin wrote: > nit: missing articles. > *The* interfaceClass property can be combined with *the* vendorId property Done.
The CQ bit was checked by tbarzic@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rdevlin.cronin@chromium.org Link to the patchset: https://codereview.chromium.org/2614663005/#ps100001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484283421665920,
"parent_rev": "0562259b2ac8d61de08dfbed6b13b9050bda9c0a", "commit_rev":
"aea9d3950199ed22d60da79e6bd5b72c106f5775"}
Message was sent while issue was closed.
Description was changed from ========== Enable USB device permission for interface class for stable BUG=629223 ========== to ========== Enable USB device permission for interface class for stable BUG=629223 Review-Url: https://codereview.chromium.org/2614663005 Cr-Commit-Position: refs/heads/master@{#443504} Committed: https://chromium.googlesource.com/chromium/src/+/aea9d3950199ed22d60da79e6bd5... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/aea9d3950199ed22d60da79e6bd5... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
