Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2614663002: [turbofan] Recognize and optimize flooring integer division. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Recognize and optimize flooring integer division. Recognize the special NumberFloor(NumberDivide(lhs, rhs)) subgraph in TypedOptimization, where both lhs and rhs are in the Unsigned32 range, and the result is a PlainNumber, and replace the NumberFloor with a NumberToUint32 truncation. This could be done in a cleaner way if we have a dedicated type for all double values in the Unsigned32 range, but that would complicate the type system quite a bit. R=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2614663002 Cr-Commit-Position: refs/heads/master@{#42063} Committed: https://chromium.googlesource.com/v8/v8/+/2a60fd49db2d787f0dd6a7a731485011ec89d35f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M src/compiler/typed-optimization.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typed-optimization.cc View 2 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-04 10:00:06 UTC) #1
Jarin
lgtm
3 years, 11 months ago (2017-01-04 10:04:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614663002/1
3 years, 11 months ago (2017-01-04 10:11:03 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 10:24:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2a60fd49db2d787f0dd6a7a731485011ec8...

Powered by Google App Engine
This is Rietveld 408576698