Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2614643002: Switch IsValueInRangeForNumericType to IsValid() (Closed)

Created:
3 years, 11 months ago by jschuh
Modified:
3 years, 11 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch IsValueInRangeForNumericType to IsValid() TBR=tsepez Committed: https://crrev.com/00c3bd0ec7526fec7e5078c92e776e2cc6e3d9d3 Cr-Commit-Position: refs/heads/master@{#441348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M base/numerics/safe_conversions.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614643002/1
3 years, 11 months ago (2017-01-04 07:41:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 09:42:27 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 09:45:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00c3bd0ec7526fec7e5078c92e776e2cc6e3d9d3
Cr-Commit-Position: refs/heads/master@{#441348}

Powered by Google App Engine
This is Rietveld 408576698