[promises] Move PromiseFulfill to TF

[promises] Move PromiseFulfill to TF

BUG=v8:5343
Review-Url: https://codereview.chromium.org/2614603003
Cr-Commit-Position: refs/heads/master@{#42073}
Committed: https://chromium.googlesource.com/v8/v8/+/a18de9cfa8d263b8bd415e2d7d106d48bc3d381d

[gsathya, 2017-01-04 02:39:37]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 02:39:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2017-01-04 02:48:12]

Description was changed from

==========
[promises] Move PromiseFulfill to TF

BUG=v8:5343
==========

to

==========
[promises] Move PromiseFulfill to TF

BUG=v8:5343
==========

[gsathya, 2017-01-04 02:48:12]

gsathya@chromium.org changed reviewers:
+ ishell@chromium.org

[commit-bot: I haz the power, 2017-01-04 03:15:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 03:15:26]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-01-04 08:39:32]

lgtm once the comments are addressed.

https://codereview.chromium.org/2614603003/diff/1/src/builtins/builtins-promi...
File src/builtins/builtins-promise.cc (right):

https://codereview.chromium.org/2614603003/diff/1/src/builtins/builtins-promi...
src/builtins/builtins-promise.cc:756: Node* const tasks = SelectConstant(
Please use Select() here otherwise both Fulfill and Reject fields will be
loaded.

https://codereview.chromium.org/2614603003/diff/1/src/builtins/builtins-promi...
src/builtins/builtins-promise.cc:757: SmiEqual(status_smi,
SmiConstant(v8::Promise::kFulfilled)),
BTW, this check looks like a compile-time one.

[gsathya, 2017-01-04 19:37:56]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 19:38:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2017-01-04 19:51:01]

https://codereview.chromium.org/2614603003/diff/1/src/builtins/builtins-promi...
File src/builtins/builtins-promise.cc (right):

https://codereview.chromium.org/2614603003/diff/1/src/builtins/builtins-promi...
src/builtins/builtins-promise.cc:756: Node* const tasks = SelectConstant(
On 2017/01/04 08:39:32, Igor Sheludko wrote:
> Please use Select() here otherwise both Fulfill and Reject fields will be
> loaded.

Done.

https://codereview.chromium.org/2614603003/diff/1/src/builtins/builtins-promi...
src/builtins/builtins-promise.cc:757: SmiEqual(status_smi,
SmiConstant(v8::Promise::kFulfilled)),
On 2017/01/04 08:39:32, Igor Sheludko wrote:
> BTW, this check looks like a compile-time one.

Done.

[commit-bot: I haz the power, 2017-01-04 20:10:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 20:10:01]

Dry run: This issue passed the CQ dry run.

[gsathya, 2017-01-04 20:10:16]

The CQ bit was checked by gsathya@chromium.org

[gsathya, 2017-01-04 20:10:16]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2614603003/#ps20001
(title: "fix nits")

[commit-bot: I haz the power, 2017-01-04 20:10:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 20:11:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 20:12:00]

Failed to apply patch for src/builtins/builtins-promise.h:
While running git apply --index -p1;
  error: patch failed: src/builtins/builtins-promise.h:55
  error: src/builtins/builtins-promise.h: patch does not apply

Patch:       src/builtins/builtins-promise.h
Index: src/builtins/builtins-promise.h
diff --git a/src/builtins/builtins-promise.h b/src/builtins/builtins-promise.h
index
4ceedfac22b11e56a36ca0af0c41604ec711cfbb..56000a0f2b92867f7b62f8a8d111cfdb34076fd2
100644
--- a/src/builtins/builtins-promise.h
+++ b/src/builtins/builtins-promise.h
@@ -55,6 +55,9 @@ class PromiseBuiltinsAssembler : public CodeStubAssembler {
   Node* CreatePromiseGetCapabilitiesExecutorContext(Node* native_context,
                                                     Node* promise_capability);
 
+  void PromiseFulfill(Node* context, Node* promise, Node* result,
+                      v8::Promise::PromiseState status);
+
   Node* NewPromiseCapability(Node* context, Node* constructor,
                              Node* debug_event = nullptr);
 };

[gsathya, 2017-01-04 21:01:16]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 21:01:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 21:22:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 21:22:55]

Dry run: This issue passed the CQ dry run.

[gsathya, 2017-01-04 21:57:20]

The CQ bit was checked by gsathya@chromium.org

[gsathya, 2017-01-04 21:57:21]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2614603003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-04 21:57:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 21:59:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483567040529960,
"parent_rev": "3e20d381eddec3198ef0de790f099bd0c08bbb33", "commit_rev":
"a18de9cfa8d263b8bd415e2d7d106d48bc3d381d"}

[commit-bot: I haz the power, 2017-01-04 21:59:12]

Description was changed from

==========
[promises] Move PromiseFulfill to TF

BUG=v8:5343
==========

to

==========
[promises] Move PromiseFulfill to TF

BUG=v8:5343

Review-Url: https://codereview.chromium.org/2614603003
Cr-Commit-Position: refs/heads/master@{#42073}
Committed:
https://chromium.googlesource.com/v8/v8/+/a18de9cfa8d263b8bd415e2d7d106d48bc3...
==========

[commit-bot: I haz the power, 2017-01-04 21:59:14]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/a18de9cfa8d263b8bd415e2d7d106d48bc3...