Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2614603002: Move core/dom timers to frame-specific task runners. (Closed)

Created:
3 years, 11 months ago by dcheng
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move core/dom timers to frame-specific task runners. - CSSSelectorWatch is used to implement a Blink public API that supports the chrome.declarativeContent [1] extension API. This is an internal implementation detail of Chrome, and has been moved to the unspecced timer task source. - The presentation attribute [2] cache cleaner remains as-is, since it's a static cleaner shared among different frames. [1] https://developer.chrome.com/extensions/declarativeContent [2] e.g. bgcolor, topmargin, etc attributes on a body element BUG=624694 Committed: https://crrev.com/e77aadd2660b37e28778fe0f9e423ca941b24722 Cr-Commit-Position: refs/heads/master@{#441311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/CSSSelectorWatch.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
dcheng
3 years, 11 months ago (2017-01-04 01:48:45 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-04 02:13:11 UTC) #5
dcheng
On 2017/01/04 02:13:11, haraken wrote: > LGTM Btw, do we plan on categorizing unspecced sources ...
3 years, 11 months ago (2017-01-04 02:19:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614603002/1
3 years, 11 months ago (2017-01-04 02:19:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 03:35:54 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e77aadd2660b37e28778fe0f9e423ca941b24722 Cr-Commit-Position: refs/heads/master@{#441311}
3 years, 11 months ago (2017-01-04 03:39:33 UTC) #14
haraken
3 years, 11 months ago (2017-01-04 11:44:09 UTC) #15
Message was sent while issue was closed.
On 2017/01/04 02:19:17, dcheng wrote:
> On 2017/01/04 02:13:11, haraken wrote:
> > LGTM
> 
> Btw, do we plan on categorizing unspecced sources with more detail in the
> future? Since this seems like something that won't ever be specced.

Not really. We have UnspecedTimer and UnspecedLoading. That's it.

"Unspeced" means a task not defined in the spec (i.e., an internal task in
Blink). It doesn't mean a task that is defined in the spec but is not yet
associated with any task source. There's a discussion to introduce
"PlatformAPITask" to distinct between the two.

Powered by Google App Engine
This is Rietveld 408576698