[wasm][asm.js] Cancel exception and rethrow on parse failure.

[wasm][asm.js] Cancel exception and rethrow on parse failure.

BUG=674089
R=marja@chromium.org

Review-Url: https://codereview.chromium.org/2614563002
Cr-Commit-Position: refs/heads/master@{#42440}
Committed: https://chromium.googlesource.com/v8/v8/+/5c8022e6383370c10676ae8f5a6acaa358a7f33a

[bradnelson, 2017-01-03 23:19:36]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 23:19:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 23:44:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 23:44:10]

Dry run: This issue passed the CQ dry run.

[marja, 2017-01-04 09:56:51]

Could you also add the test from the bug?

https://codereview.chromium.org/2614563002/diff/1/src/asmjs/asm-wasm-builder.cc
File src/asmjs/asm-wasm-builder.cc (right):

https://codereview.chromium.org/2614563002/diff/1/src/asmjs/asm-wasm-builder....
src/asmjs/asm-wasm-builder.cc:159: isolate_->clear_pending_exception();
What if we fail the parsing because of the call stack limit is exceeded? At that
point we don't have a pending exception afaik, and clear_pending_exception
assumes we do.

[bradnelson, 2017-01-18 08:57:51]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 08:58:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradnelson, 2017-01-18 09:00:37]

Figured out the issue with --ignition-staging had to do with the declaration
scope created in the per function parse zone sticking around for when ignition
goes back to parse the module function again.
This now seems to fix things for both --validate-asm and --ignition-staging

PTAL

https://codereview.chromium.org/2614563002/diff/1/src/asmjs/asm-wasm-builder.cc
File src/asmjs/asm-wasm-builder.cc (right):

https://codereview.chromium.org/2614563002/diff/1/src/asmjs/asm-wasm-builder....
src/asmjs/asm-wasm-builder.cc:159: isolate_->clear_pending_exception();
On 2017/01/04 09:56:51, marja wrote:
> What if we fail the parsing because of the call stack limit is exceeded? At
that
> point we don't have a pending exception afaik, and clear_pending_exception
> assumes we do.

Checking before clearing.

[marja, 2017-01-18 09:12:00]

lgtm

[bradn, 2017-01-18 09:18:51]

The CQ bit was unchecked by bradnelson@google.com

[bradn, 2017-01-18 09:18:52]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2017-01-18 09:18:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 09:23:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484731132308110,
"parent_rev": "48eabdcf72576d5184a931906455d4e691c00d6b", "commit_rev":
"5c8022e6383370c10676ae8f5a6acaa358a7f33a"}

[commit-bot: I haz the power, 2017-01-18 09:23:18]

Description was changed from

==========
[wasm][asm.js] Cancel exception and rethrow on parse failure.

BUG=674089
R=marja@chromium.org
==========

to

==========
[wasm][asm.js] Cancel exception and rethrow on parse failure.

BUG=674089
R=marja@chromium.org

Review-Url: https://codereview.chromium.org/2614563002
Cr-Commit-Position: refs/heads/master@{#42440}
Committed:
https://chromium.googlesource.com/v8/v8/+/5c8022e6383370c10676ae8f5a6acaa358a...
==========

[commit-bot: I haz the power, 2017-01-18 09:23:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/5c8022e6383370c10676ae8f5a6acaa358a...