Don't sync DOM selection for root a11y node

Don't sync DOM selection for root a11y node

BUG=677885
Committed: https://crrev.com/7caf9d35a14e3c4c093f2975df34d77b9dc035ed
Cr-Commit-Position: refs/heads/master@{#441299}

[aboxhall, 2017-01-03 23:36:54]

aboxhall@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2017-01-04 00:11:05]

I like it! lgtm

https://codereview.chromium.org/2614553002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js
(right):

https://codereview.chromium.org/2614553002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js:92:
function nodeResolved(node) {
Can use arrow function instead.

https://codereview.chromium.org/2614553002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js:160:
this._treePane.setSelectedNode(this._axNode);
Does it make sense to merge setSelectedByUser and setSelectedNode now?

[aboxhall, 2017-01-04 01:06:10]

https://codereview.chromium.org/2614553002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js
(right):

https://codereview.chromium.org/2614553002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js:92:
function nodeResolved(node) {
On 2017/01/04 00:11:05, dgozman wrote:
> Can use arrow function instead.

Done.

https://codereview.chromium.org/2614553002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js:160:
this._treePane.setSelectedNode(this._axNode);
On 2017/01/04 00:11:05, dgozman wrote:
> Does it make sense to merge setSelectedByUser and setSelectedNode now?

I wanted to leave them separate, since it's plausible that setSelectedNode may
be called from a context which is not user-initiated.

[aboxhall, 2017-01-04 01:06:14]

The CQ bit was checked by aboxhall@chromium.org

[aboxhall, 2017-01-04 01:06:14]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2614553002/#ps20001
(title: "Use arrow function")

[commit-bot: I haz the power, 2017-01-04 01:06:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 02:35:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483491974245110,
"parent_rev": "903c0201f80af9289bf811b26dfeae7412ec3024", "commit_rev":
"ecc6d571ec76109d9173e104a65f4795b07d5ee7"}

[commit-bot: I haz the power, 2017-01-04 02:36:25]

Description was changed from

==========
Don't sync DOM selection for root a11y node

BUG=677885
==========

to

==========
Don't sync DOM selection for root a11y node

BUG=677885

Review-Url: https://codereview.chromium.org/2614553002
==========

[commit-bot: I haz the power, 2017-01-04 02:36:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-04 02:40:09]

Description was changed from

==========
Don't sync DOM selection for root a11y node

BUG=677885

Review-Url: https://codereview.chromium.org/2614553002
==========

to

==========
Don't sync DOM selection for root a11y node

BUG=677885

Committed: https://crrev.com/7caf9d35a14e3c4c093f2975df34d77b9dc035ed
Cr-Commit-Position: refs/heads/master@{#441299}
==========

[commit-bot: I haz the power, 2017-01-04 02:40:12]

Patchset 2 (id:??) landed as
https://crrev.com/7caf9d35a14e3c4c093f2975df34d77b9dc035ed
Cr-Commit-Position: refs/heads/master@{#441299}