Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2614533003: X87: [Ignition] Teach CompileLazy about interpreted functions. (Closed)

Created:
3 years, 11 months ago by zhengxing.li
Modified:
3 years, 11 months ago
Reviewers:
chunyang.dai, rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Ignition] Teach CompileLazy about interpreted functions. port 72c370767226cf573d316655b1d3e3d3d699cc9b(r42034) original commit message: Currently the CompileLazy builtin checks the SFI expliciltly for FCG code. This means if the SFI has bytecode we have to go through to the runtime to install the interpreter entry trampoline into the JSFunction object. Modify the builtin to always put the SFI code object into the JSFunction unless it's the lazy compile stub on the SFI as well. BUG= Review-Url: https://codereview.chromium.org/2614533003 Cr-Commit-Position: refs/heads/master@{#42081} Committed: https://chromium.googlesource.com/v8/v8/+/c4e0b1598148613963925846ef05184245cd8b53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/builtins/x87/builtins-x87.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zhengxing.li
PTAL, thanks!
3 years, 11 months ago (2017-01-04 02:01:12 UTC) #2
chunyang.dai
On 2017/01/04 02:01:12, zhengxing.li wrote: > PTAL, thanks! LGTM. thanks
3 years, 11 months ago (2017-01-05 06:32:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614533003/1
3 years, 11 months ago (2017-01-05 06:45:58 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 07:07:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c4e0b1598148613963925846ef05184245c...

Powered by Google App Engine
This is Rietveld 408576698