Add server_url and mime_type params to CreateUploader.

Add server_url and mime_type params to CreateUploader.

This will allow for reuse by Rappor/UKM.

BUG=678682
Review-Url: https://codereview.chromium.org/2614533002
Cr-Commit-Position: refs/heads/master@{#441809}
Committed: https://chromium.googlesource.com/chromium/src/+/567a16f2ec90d6a0fc34a5039f53e0d4088931b9

[Steven Holte, 2017-01-03 22:27:40]

holte@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Steven Holte, 2017-01-03 22:27:40]

Splitting this from https://codereview.chromium.org/2567263003/

[rkaplow, 2017-01-04 17:59:03]

lgtm

[chromium-reviews, 2017-01-04 18:15:37]

drive-by: can you file a crbug to track all the UKM stuff and set it as
BUG= on the CLs?

On Wed, Jan 4, 2017 at 12:59 PM, <rkaplow@chromium.org> wrote:

> lgtm
>
>
>
> https://codereview.chromium.org/2614533002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Steven Holte, 2017-01-04 21:50:49]

Description was changed from

==========
Add server_url and mime_type params to CreateUploader.

This will allow for reuse by Rappor/UKM.

BUG=
==========

to

==========
Add server_url and mime_type params to CreateUploader.

This will allow for reuse by Rappor/UKM.

BUG=673020
==========

[Steven Holte, 2017-01-04 21:58:05]

holte@chromium.org changed reviewers:
+ wez@chromium.org

[Steven Holte, 2017-01-04 21:58:06]

+wez for blimp/engine/app/blimp_metrics_service_client

[Wez, 2017-01-04 23:04:26]

blimp/ LGTM

[Steven Holte, 2017-01-04 23:23:37]

The CQ bit was checked by holte@chromium.org

[commit-bot: I haz the power, 2017-01-04 23:24:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 23:31:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 23:31:04]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Steven Holte, 2017-01-04 23:34:48]

The CQ bit was checked by holte@chromium.org

[Steven Holte, 2017-01-04 23:34:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, wez@chromium.org
Link to the patchset: https://codereview.chromium.org/2614533002/#ps40001
(title: "Missing file")

[commit-bot: I haz the power, 2017-01-04 23:35:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 23:43:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 23:43:52]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Steven Holte, 2017-01-05 00:01:34]

The CQ bit was checked by holte@chromium.org

[Steven Holte, 2017-01-05 00:01:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, wez@chromium.org
Link to the patchset: https://codereview.chromium.org/2614533002/#ps60001
(title: "Fix test")

[commit-bot: I haz the power, 2017-01-05 00:02:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 00:10:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 00:10:38]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Steven Holte, 2017-01-05 00:45:48]

holte@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[Steven Holte, 2017-01-05 00:46:22]

+olivierrobin for ios/chrome/browser/metrics

[Olivier, 2017-01-05 07:41:54]

ios lgtm

[chromium-reviews, 2017-01-05 15:45:42]

> BUG=673020

I think it might be better to have a separate implementation bug than using
the launch bug. This way, launch bug comments can be more focused on the
approvals and such and the implementation CLs can be on a different bug.
You can mark the impl bug as blocking the launch bug in crbug.

On Thu, Jan 5, 2017 at 2:41 AM, <olivierrobin@chromium.org> wrote:

> ios lgtm
>
> https://codereview.chromium.org/2614533002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Steven Holte, 2017-01-05 18:47:59]

Description was changed from

==========
Add server_url and mime_type params to CreateUploader.

This will allow for reuse by Rappor/UKM.

BUG=673020
==========

to

==========
Add server_url and mime_type params to CreateUploader.

This will allow for reuse by Rappor/UKM.

BUG=678682
==========

[Steven Holte, 2017-01-05 18:48:12]

On 2017/01/05 15:45:42, chromium-reviews wrote:
> > BUG=673020
> 
> I think it might be better to have a separate implementation bug than using
> the launch bug. This way, launch bug comments can be more focused on the
> approvals and such and the implementation CLs can be on a different bug.
> You can mark the impl bug as blocking the launch bug in crbug.
> 
> On Thu, Jan 5, 2017 at 2:41 AM, <mailto:olivierrobin@chromium.org> wrote:
> 
> > ios lgtm
> >
> > https://codereview.chromium.org/2614533002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Done

[Steven Holte, 2017-01-05 18:48:30]

The CQ bit was checked by holte@chromium.org

[Steven Holte, 2017-01-05 18:48:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, wez@chromium.org
Link to the patchset: https://codereview.chromium.org/2614533002/#ps80001
(title: "iOS MetricsServiceClient")

[commit-bot: I haz the power, 2017-01-05 18:49:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 18:56:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 18:56:32]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Steven Holte, 2017-01-05 20:14:56]

holte@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Steven Holte, 2017-01-05 20:14:56]

+tobiasjs for android_webview/browser/aw_metrics_service_client.*
+asvitkine for chromecast/browser/metrics

FYI olivierrobin@, I also added the one in ios/chrome/today_extension

Am I missing any more of these?

[Alexei Svitkine (slow), 2017-01-05 20:26:24]

lgtm

[Steven Holte, 2017-01-05 21:19:42]

holte@chromium.org changed reviewers:
+ boliu@chromium.org

[Steven Holte, 2017-01-05 21:19:43]

+boliu for android_webview, since tobiasjs is OOO.

[boliu, 2017-01-05 22:15:55]

lgtm

[Steven Holte, 2017-01-05 22:19:05]

The CQ bit was checked by holte@chromium.org

[Steven Holte, 2017-01-05 22:19:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, olivierrobin@chromium.org, wez@chromium.org
Link to the patchset: https://codereview.chromium.org/2614533002/#ps100001
(title: "Chromecast + Android Webview")

[commit-bot: I haz the power, 2017-01-05 22:19:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 22:27:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 22:27:14]

Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Steven Holte, 2017-01-05 22:52:45]

The CQ bit was checked by holte@chromium.org

[Steven Holte, 2017-01-05 22:52:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, asvitkine@chromium.org, olivierrobin@chromium.org,
wez@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2614533002/#ps120001
(title: "Missing Include")

[commit-bot: I haz the power, 2017-01-05 22:53:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 01:53:49]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1483656765073860,
"parent_rev": "2f4dfeb1e88df2f17e746e3f5b56fa54f59e0e15", "commit_rev":
"567a16f2ec90d6a0fc34a5039f53e0d4088931b9"}

[commit-bot: I haz the power, 2017-01-06 01:54:19]

Description was changed from

==========
Add server_url and mime_type params to CreateUploader.

This will allow for reuse by Rappor/UKM.

BUG=678682
==========

to

==========
Add server_url and mime_type params to CreateUploader.

This will allow for reuse by Rappor/UKM.

BUG=678682

Review-Url: https://codereview.chromium.org/2614533002
Cr-Commit-Position: refs/heads/master@{#441809}
Committed:
https://chromium.googlesource.com/chromium/src/+/567a16f2ec90d6a0fc34a5039f53...
==========

[commit-bot: I haz the power, 2017-01-06 01:54:21]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/567a16f2ec90d6a0fc34a5039f53...