Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2614493003: Manage OffscreenCanvasCompositorFrameSink lifetime explicitly (Closed)

Created:
3 years, 11 months ago by Fady Samuel
Modified:
3 years, 11 months ago
Reviewers:
danakj, xlai (Olivia), jam
CC:
chromium-reviews, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manage OffscreenCanvasCompositorFrameSink lifetime explicitly The lifetime of mojo::StrongBindings is hard to reason about. This CL manages OffscreenCanvasCompositorFrameSink(ProviderImpl) lifetime explicitly. In particular, their lifetime is bound to the lifetime of the RenderProcessHostImpl. BUG=675109 Review-Url: https://codereview.chromium.org/2614493003 Cr-Commit-Position: refs/heads/master@{#441687} Committed: https://chromium.googlesource.com/chromium/src/+/2c16ab44ad1354882c47d7ed49a4c5d77441857b

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -34 lines) Patch
M content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.h View 2 chunks +9 lines, -7 lines 0 comments Download
M content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc View 2 chunks +20 lines, -17 lines 0 comments Download
M content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.h View 2 chunks +19 lines, -1 line 0 comments Download
M content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.cc View 1 chunk +16 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 3 chunks +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
Fady Samuel
PTAL Dana! How does this approach look to you? Thanks!
3 years, 11 months ago (2017-01-04 01:11:37 UTC) #2
Fady Samuel
+xlai@ for offscreen canvas.
3 years, 11 months ago (2017-01-04 16:30:29 UTC) #9
Fady Samuel
+xlai@ for offscreen canvas.
3 years, 11 months ago (2017-01-04 16:30:29 UTC) #10
xlai (Olivia)
On 2017/01/04 16:30:29, Fady Samuel wrote: > +xlai@ for offscreen canvas. The logic lgtm. You ...
3 years, 11 months ago (2017-01-04 17:00:39 UTC) #11
Fady Samuel
+jam@ for content/
3 years, 11 months ago (2017-01-04 17:01:12 UTC) #13
jam
On 2017/01/04 17:01:12, Fady Samuel wrote: > +jam@ for content/ rs lgtm but please add ...
3 years, 11 months ago (2017-01-04 19:10:33 UTC) #14
Fady Samuel
On 2017/01/04 19:10:33, jam wrote: > On 2017/01/04 17:01:12, Fady Samuel wrote: > > +jam@ ...
3 years, 11 months ago (2017-01-05 16:27:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614493003/20001
3 years, 11 months ago (2017-01-05 16:27:31 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 17:26:19 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2c16ab44ad1354882c47d7ed49a4...

Powered by Google App Engine
This is Rietveld 408576698