Manage OffscreenCanvasCompositorFrameSink lifetime explicitly

Manage OffscreenCanvasCompositorFrameSink lifetime explicitly

The lifetime of mojo::StrongBindings is hard to reason about. This CL
manages OffscreenCanvasCompositorFrameSink(ProviderImpl) lifetime explicitly.
In particular, their lifetime is bound to the lifetime of the
RenderProcessHostImpl.

BUG=675109
Review-Url: https://codereview.chromium.org/2614493003
Cr-Commit-Position: refs/heads/master@{#441687}
Committed: https://chromium.googlesource.com/chromium/src/+/2c16ab44ad1354882c47d7ed49a4c5d77441857b

[Fady Samuel, 2017-01-04 01:11:37]

fsamuel@chromium.org changed reviewers:
+ danakj@chromium.org

[Fady Samuel, 2017-01-04 01:11:37]

PTAL Dana! How does this approach look to you? Thanks!

[Fady Samuel, 2017-01-04 02:51:48]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 02:52:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 03:45:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 03:45:42]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2017-01-04 16:30:29]

fsamuel@chromium.org changed reviewers:
+ xlai@chromium.org

[Fady Samuel, 2017-01-04 16:30:29]

fsamuel@chromium.org changed reviewers:
+ xlai@chromium.org

[Fady Samuel, 2017-01-04 16:30:29]

+xlai@ for offscreen canvas.

[Fady Samuel, 2017-01-04 16:30:29]

+xlai@ for offscreen canvas.

[xlai (Olivia), 2017-01-04 17:00:39]

On 2017/01/04 16:30:29, Fady Samuel wrote:
> +xlai@ for offscreen canvas.

The logic lgtm. You need to add a content/browser reviewer as well.

[Fady Samuel, 2017-01-04 17:01:12]

fsamuel@chromium.org changed reviewers:
+ jam@chromium.org

[Fady Samuel, 2017-01-04 17:01:12]

+jam@ for content/

[jam, 2017-01-04 19:10:33]

On 2017/01/04 17:01:12, Fady Samuel wrote:
> +jam@ for content/

rs lgtm

but please add a per-file owners for offscreen_canvas_compositor_frame_sink* so
that no one has to rubberstamp changes for them.

[Fady Samuel, 2017-01-05 16:27:05]

On 2017/01/04 19:10:33, jam wrote:
> On 2017/01/04 17:01:12, Fady Samuel wrote:
> > +jam@ for content/
> 
> rs lgtm
> 
> but please add a per-file owners for offscreen_canvas_compositor_frame_sink*
so
> that no one has to rubberstamp changes for them.

offscreen canvas stuff already has per-file OWNERs. CQ'ing now.

[Fady Samuel, 2017-01-05 16:27:08]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2017-01-05 16:27:09]

The patchset sent to the CQ was uploaded after l-g-t-m from xlai@chromium.org,
jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2614493003/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2017-01-05 16:27:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 17:25:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483633628877790,
"parent_rev": "234116bf576be1dc6e43232753d3065849e6e816", "commit_rev":
"2c16ab44ad1354882c47d7ed49a4c5d77441857b"}

[commit-bot: I haz the power, 2017-01-05 17:26:18]

Description was changed from

==========
Manage OffscreenCanvasCompositorFrameSink lifetime explicitly

The lifetime of mojo::StrongBindings is hard to reason about. This CL
manages OffscreenCanvasCompositorFrameSink(ProviderImpl) lifetime explicitly.
In particular, their lifetime is bound to the lifetime of the
RenderProcessHostImpl.

BUG=675109
==========

to

==========
Manage OffscreenCanvasCompositorFrameSink lifetime explicitly

The lifetime of mojo::StrongBindings is hard to reason about. This CL
manages OffscreenCanvasCompositorFrameSink(ProviderImpl) lifetime explicitly.
In particular, their lifetime is bound to the lifetime of the
RenderProcessHostImpl.

BUG=675109

Review-Url: https://codereview.chromium.org/2614493003
Cr-Commit-Position: refs/heads/master@{#441687}
Committed:
https://chromium.googlesource.com/chromium/src/+/2c16ab44ad1354882c47d7ed49a4...
==========

[commit-bot: I haz the power, 2017-01-05 17:26:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2c16ab44ad1354882c47d7ed49a4...