Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2614463002: Media Session: MediaMetadata constructor may have 0 parameters. (Closed)

Created:
3 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, haraken, feature-media-reviews_chromium.org, blink-reviews, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Session: MediaMetadata constructor may have 0 parameters. Per spec. Also, because the dictionary has a default value for each field so passing {} or no parameter should have the same effect. BUG=677955 R=zqzhang@chromium.org Committed: https://crrev.com/1d78b4038dcf9d3d21f1045dcf1a2244a3118e3b Cr-Commit-Position: refs/heads/master@{#441349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html View 2 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaMetadata.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Zhiqiang Zhang (Slow)
lgtm
3 years, 11 months ago (2017-01-03 16:53:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614463002/1
3 years, 11 months ago (2017-01-04 09:39:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 09:43:38 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 09:47:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d78b4038dcf9d3d21f1045dcf1a2244a3118e3b
Cr-Commit-Position: refs/heads/master@{#441349}

Powered by Google App Engine
This is Rietveld 408576698