[ios] Moved all web mocks to ios/web/public/test/fakes.

[ios] Moved all web mocks to ios/web/public/test/fakes.

There are 8 fake classes and they deserve a separate directory.

BUG=None

Review-Url: https://codereview.chromium.org/2614443004
Cr-Commit-Position: refs/heads/master@{#441705}
Committed: https://chromium.googlesource.com/chromium/src/+/e81a072c1c3a108fbed9d24d62ee7c772d66f660

[Eugene But (OOO till 7-30), 2017-01-03 23:36:26]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 23:37:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2017-01-04 00:22:55]

eugenebut@chromium.org changed reviewers:
+ sdefresne@chromium.org

[commit-bot: I haz the power, 2017-01-04 01:11:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 01:11:19]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-01-04 10:37:19]

I don't think those objects (except for mock_image_data_fetcher.h) are mocks.
According to most unit test framework a mock is an object where you set
expectation and assert that the expected methods have been called. Thus I think
the directory name is misleading.

Here we have a collection of simpler implementation of complex interfaces that
can be used as stubs during the unit tests (TestWebState, ...) or helper classes
to initialise some global state (TestWebThreadBundle).

If we want to move those files to sub-directories to represent what they are, I
think it would be better to name the directory ios/web/public/test/fakes and
ios/web/public/test/helpers (depending on the objects).

[Eugene But (OOO till 7-30), 2017-01-04 21:39:15]

Description was changed from

==========
[ios] Moved all web mocks to ios/web/public/test/mocks.

There are 22 mock files and they deserve a separate directory.

BUG=None
==========

to

==========
[ios] Moved all web mocks to ios/web/public/test/fakes.

There are 9 fake classes and they deserve a separate directory.

BUG=None
==========

[Eugene But (OOO till 7-30), 2017-01-04 22:04:59]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[Eugene But (OOO till 7-30), 2017-01-04 22:05:29]

On 2017/01/04 10:37:19, sdefresne wrote:
> I don't think those objects (except for mock_image_data_fetcher.h) are mocks.
> According to most unit test framework a mock is an object where you set
> expectation and assert that the expected methods have been called. Thus I
think
> the directory name is misleading.
> 
> Here we have a collection of simpler implementation of complex interfaces that
> can be used as stubs during the unit tests (TestWebState, ...) or helper
classes
> to initialise some global state (TestWebThreadBundle).
> 
> If we want to move those files to sub-directories to represent what they are,
I
> think it would be better to name the directory ios/web/public/test/fakes and
> ios/web/public/test/helpers (depending on the objects).
Fair point. Moved fakes to ios/web/public/test/fakes, left other files where
they were. PTAL.

[commit-bot: I haz the power, 2017-01-04 22:05:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 23:19:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 23:19:32]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-01-05 10:50:46]

lgtm except maybe for ios/web/public/test/fakes/test_redirect_observer.h

https://codereview.chromium.org/2614443004/diff/20001/ios/web/public/test/fak...
File ios/web/public/test/fakes/test_redirect_observer.h (right):

https://codereview.chromium.org/2614443004/diff/20001/ios/web/public/test/fak...
ios/web/public/test/fakes/test_redirect_observer.h:20: class
TestRedirectObserver : public web::WebStateObserver {
This one does not look like a fake but instead is a helper.

[Eugene But (OOO till 7-30), 2017-01-05 17:24:54]

Description was changed from

==========
[ios] Moved all web mocks to ios/web/public/test/fakes.

There are 9 fake classes and they deserve a separate directory.

BUG=None
==========

to

==========
[ios] Moved all web mocks to ios/web/public/test/fakes.

There are 8 fake classes and they deserve a separate directory.

BUG=None
==========

[Eugene But (OOO till 7-30), 2017-01-05 17:25:06]

Thanks!

https://codereview.chromium.org/2614443004/diff/20001/ios/web/public/test/fak...
File ios/web/public/test/fakes/test_redirect_observer.h (right):

https://codereview.chromium.org/2614443004/diff/20001/ios/web/public/test/fak...
ios/web/public/test/fakes/test_redirect_observer.h:20: class
TestRedirectObserver : public web::WebStateObserver {
On 2017/01/05 10:50:46, sdefresne wrote:
> This one does not look like a fake but instead is a helper.
Good point. Done.

[Eugene But (OOO till 7-30), 2017-01-05 17:25:10]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-01-05 17:25:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2614443004/#ps40001
(title: "Moved test_redirect_observer back")

[commit-bot: I haz the power, 2017-01-05 17:25:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 18:34:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483637110688710,
"parent_rev": "4f23c751e592725b9638a5992a81a31a2dddc391", "commit_rev":
"e81a072c1c3a108fbed9d24d62ee7c772d66f660"}

[commit-bot: I haz the power, 2017-01-05 18:34:39]

Description was changed from

==========
[ios] Moved all web mocks to ios/web/public/test/fakes.

There are 8 fake classes and they deserve a separate directory.

BUG=None
==========

to

==========
[ios] Moved all web mocks to ios/web/public/test/fakes.

There are 8 fake classes and they deserve a separate directory.

BUG=None

Review-Url: https://codereview.chromium.org/2614443004
Cr-Commit-Position: refs/heads/master@{#441705}
Committed:
https://chromium.googlesource.com/chromium/src/+/e81a072c1c3a108fbed9d24d62ee...
==========

[commit-bot: I haz the power, 2017-01-05 18:34:41]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e81a072c1c3a108fbed9d24d62ee...