Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2614433002: Revert of Use background tasks for the compiler dispatcher (Closed)

Created:
3 years, 11 months ago by rmcilroy
Modified:
3 years, 11 months ago
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use background tasks for the compiler dispatcher (patchset #5 id:80001 of https://codereview.chromium.org/2606263002/ ) Reason for revert: Causes IgnitionCompilerDispatcherTest.FinishNowWithBackgroundTask to fail. https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/11209 Original issue's description: > Use background tasks for the compiler dispatcher > > BUG=v8:5215 > R=marja@chromium.org,vogelheim@chromium.org > > Review-Url: https://codereview.chromium.org/2606263002 > Cr-Commit-Position: refs/heads/master@{#42035} > Committed: https://chromium.googlesource.com/v8/v8/+/7a1b3a7bebbef88e72c9f7747e1930f10ee10c80 TBR=marja@chromium.org,vogelheim@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5215 Review-Url: https://codereview.chromium.org/2614433002 Cr-Commit-Position: refs/heads/master@{#42037} Committed: https://chromium.googlesource.com/v8/v8/+/d4b5bfe306077f8f96a2c572f18aac0118b60477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -438 lines) Patch
M src/cancelable-task.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/cancelable-task.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher.h View 5 chunks +1 line, -58 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher.cc View 7 chunks +32 lines, -179 lines 0 comments Download
M test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc View 8 chunks +12 lines, -191 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmcilroy
Created Revert of Use background tasks for the compiler dispatcher
3 years, 11 months ago (2017-01-03 15:51:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614433002/1
3 years, 11 months ago (2017-01-03 15:51:37 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 15:51:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d4b5bfe306077f8f96a2c572f18aac0118b...

Powered by Google App Engine
This is Rietveld 408576698