Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2614403002: Move STATIC_HISTOGRAM_POINTER_GROUP into histogram_macros.h. (Closed)

Created:
3 years, 11 months ago by tdresser
Modified:
3 years, 11 months ago
Reviewers:
Ilya Sherman, sadrul
CC:
chromium-reviews, tdresser+watch_chromium.org, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move STATIC_HISTOGRAM_POINTER_GROUP into histogram_macros.h. This will be used to simplify some of the performance critical logic in render_widget_host_latency_tracker.cc. Review-Url: https://codereview.chromium.org/2614403002 Cr-Commit-Position: refs/heads/master@{#443551} Committed: https://chromium.googlesource.com/chromium/src/+/dbfe909f3404ff148339c0396556d6350b21cba6

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M base/metrics/histogram_macros.h View 1 1 chunk +33 lines, -0 lines 0 comments Download
M ui/events/event.cc View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
tdresser
As discussed in https://codereview.chromium.org/2570893003/.
3 years, 11 months ago (2017-01-09 15:17:55 UTC) #2
Ilya Sherman
Thanks! https://codereview.chromium.org/2614403002/diff/1/base/metrics/histogram_macros.h File base/metrics/histogram_macros.h (right): https://codereview.chromium.org/2614403002/diff/1/base/metrics/histogram_macros.h#newcode284 base/metrics/histogram_macros.h:284: // one by its index. nit: You've currently ...
3 years, 11 months ago (2017-01-09 22:51:45 UTC) #3
tdresser
https://codereview.chromium.org/2614403002/diff/1/base/metrics/histogram_macros.h File base/metrics/histogram_macros.h (right): https://codereview.chromium.org/2614403002/diff/1/base/metrics/histogram_macros.h#newcode284 base/metrics/histogram_macros.h:284: // one by its index. On 2017/01/09 22:51:45, Ilya ...
3 years, 11 months ago (2017-01-11 18:14:50 UTC) #4
Ilya Sherman
LGTM, thanks.
3 years, 11 months ago (2017-01-12 00:53:13 UTC) #5
tdresser
+sadrul for event.cc changes.
3 years, 11 months ago (2017-01-12 14:42:49 UTC) #9
sadrul
lgtm
3 years, 11 months ago (2017-01-13 02:12:58 UTC) #10
allysia153
3 years, 11 months ago (2017-01-13 08:47:52 UTC) #11
allysia153
On 2017/01/13 08:47:52, allysia153 wrote:
3 years, 11 months ago (2017-01-13 08:48:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614403002/20001
3 years, 11 months ago (2017-01-13 13:05:01 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 14:03:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dbfe909f3404ff148339c0396556...

Powered by Google App Engine
This is Rietveld 408576698