Move STATIC_HISTOGRAM_POINTER_GROUP into histogram_macros.h.

Move STATIC_HISTOGRAM_POINTER_GROUP into histogram_macros.h.

This will be used to simplify some of the performance critical
logic in render_widget_host_latency_tracker.cc.

Review-Url: https://codereview.chromium.org/2614403002
Cr-Commit-Position: refs/heads/master@{#443551}
Committed: https://chromium.googlesource.com/chromium/src/+/dbfe909f3404ff148339c0396556d6350b21cba6

[tdresser, 2017-01-09 15:17:55]

tdresser@chromium.org changed reviewers:
+ isherman@chromium.org

[tdresser, 2017-01-09 15:17:55]

As discussed in https://codereview.chromium.org/2570893003/.

[Ilya Sherman, 2017-01-09 22:51:45]

Thanks!

https://codereview.chromium.org/2614403002/diff/1/base/metrics/histogram_macr...
File base/metrics/histogram_macros.h (right):

https://codereview.chromium.org/2614403002/diff/1/base/metrics/histogram_macr...
base/metrics/histogram_macros.h:284: // one by its index.
nit: You've currently added this under the "Deprecated histogram macros"
section.  Please create a new section to contain this macro (unless there's
already an existing section that fits the bill; if so, then please use that.)

https://codereview.chromium.org/2614403002/diff/1/base/metrics/histogram_macr...
base/metrics/histogram_macros.h:291: //         
GetHistogramNameForType(histogram_index),
nit: s/Type/Index

[tdresser, 2017-01-11 18:14:50]

https://codereview.chromium.org/2614403002/diff/1/base/metrics/histogram_macr...
File base/metrics/histogram_macros.h (right):

https://codereview.chromium.org/2614403002/diff/1/base/metrics/histogram_macr...
base/metrics/histogram_macros.h:284: // one by its index.
On 2017/01/09 22:51:45, Ilya Sherman wrote:
> nit: You've currently added this under the "Deprecated histogram macros"
> section.  Please create a new section to contain this macro (unless there's
> already an existing section that fits the bill; if so, then please use that.)

Whoops. Fixed.

https://codereview.chromium.org/2614403002/diff/1/base/metrics/histogram_macr...
base/metrics/histogram_macros.h:291: //         
GetHistogramNameForType(histogram_index),
On 2017/01/09 22:51:45, Ilya Sherman wrote:
> nit: s/Type/Index

Done.

[Ilya Sherman, 2017-01-12 00:53:13]

LGTM, thanks.

[tdresser, 2017-01-12 14:42:26]

The CQ bit was checked by tdresser@chromium.org

[tdresser, 2017-01-12 14:42:27]

The CQ bit was unchecked by tdresser@chromium.org

[tdresser, 2017-01-12 14:42:49]

tdresser@chromium.org changed reviewers:
+ sadrul@chromium.org

[tdresser, 2017-01-12 14:42:49]

+sadrul for event.cc changes.

[sadrul, 2017-01-13 02:12:58]

lgtm

[allysia153, 2017-01-13 08:48:34]

On 2017/01/13 08:47:52, allysia153 wrote:

[tdresser, 2017-01-13 13:04:52]

The CQ bit was checked by tdresser@chromium.org

[commit-bot: I haz the power, 2017-01-13 13:05:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 14:03:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484312692708930,
"parent_rev": "3cf8939974888a7d5425c244f8962822a642d346", "commit_rev":
"dbfe909f3404ff148339c0396556d6350b21cba6"}

[commit-bot: I haz the power, 2017-01-13 14:03:48]

Description was changed from

==========
Move STATIC_HISTOGRAM_POINTER_GROUP into histogram_macros.h.

This will be used to simplify some of the performance critical
logic in render_widget_host_latency_tracker.cc.
==========

to

==========
Move STATIC_HISTOGRAM_POINTER_GROUP into histogram_macros.h.

This will be used to simplify some of the performance critical
logic in render_widget_host_latency_tracker.cc.

Review-Url: https://codereview.chromium.org/2614403002
Cr-Commit-Position: refs/heads/master@{#443551}
Committed:
https://chromium.googlesource.com/chromium/src/+/dbfe909f3404ff148339c0396556...
==========

[commit-bot: I haz the power, 2017-01-13 14:03:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dbfe909f3404ff148339c0396556...