Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 2614353002: Revert of Ensure navigator.getVRDisplays always resolves. (Closed)

Created:
3 years, 11 months ago by Tobias Sargeant
Modified:
3 years, 11 months ago
CC:
blink-reviews, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, feature-vr-reviews_chromium.org, haraken, jam, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Ensure navigator.getVRDisplays always resolves. (patchset #6 id:100001 of https://codereview.chromium.org/2614873002/ ) Reason for revert: Caused builder failures(e.g. https://uberchromegw.corp.google.com/i/internal.client.clank/builders/x64-builder) when building blimp. undefined reference to `device::mojom::VRService::Name_' Original issue's description: > Ensure navigator.getVRDisplays always resolves. > > In the case that the backing VR service is not available the call will now > resolve to an empty array. > > BUG=678283 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2614873002 > Cr-Commit-Position: refs/heads/master@{#442117} > Committed: https://chromium.googlesource.com/chromium/src/+/d83aedbf719e5346d2de69a79b5a1d7e9b6c8462 TBR=rockot@chromium.org,alexmos@chromium.org,ddorwin@chromium.org,bajones@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=678283 Review-Url: https://codereview.chromium.org/2614353002 Cr-Commit-Position: refs/heads/master@{#442244} Committed: https://chromium.googlesource.com/chromium/src/+/62938a72f596f94b55e7c8f4f152b2460554e178

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -35 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 3 chunks +2 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/vr/getVRDisplays_always_resolves.html View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.cpp View 3 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Tobias Sargeant
Created Revert of Ensure navigator.getVRDisplays always resolves.
3 years, 11 months ago (2017-01-09 12:02:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614353002/1
3 years, 11 months ago (2017-01-09 12:02:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/62938a72f596f94b55e7c8f4f152b2460554e178
3 years, 11 months ago (2017-01-09 13:19:35 UTC) #6
pkotwicz
3 years, 11 months ago (2017-01-09 19:28:08 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698