Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2614343002: Prerender: Use NavigationToParseStart in PrerenderBrowserTest. (Closed)

Created:
3 years, 11 months ago by mattcary
Modified:
3 years, 11 months ago
Reviewers:
droger, Benoit L
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prerender: Use NavigationToParseStart in PrerenderBrowserTest. This is event is not racey like the NavigationToFirstLayout event previously used to verify when core page load metrics were being recorded. BUG=678976 TBR=droger Review-Url: https://codereview.chromium.org/2614343002 Cr-Commit-Position: refs/heads/master@{#442252} Committed: https://chromium.googlesource.com/chromium/src/+/11fb927fae6464c838261ca93e35cf21c2657e17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mattcary
3 years, 11 months ago (2017-01-09 13:11:16 UTC) #4
mattcary
+lizeb for droger TBR
3 years, 11 months ago (2017-01-09 14:48:59 UTC) #7
Benoit L
On 2017/01/09 14:48:59, mattcary wrote: > +lizeb for droger TBR lgtm
3 years, 11 months ago (2017-01-09 14:51:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614343002/1
3 years, 11 months ago (2017-01-09 14:53:54 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 15:22:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/11fb927fae6464c838261ca93e35...

Powered by Google App Engine
This is Rietveld 408576698