Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2614253003: Support both old and new MANIFEST.json formats, and update baselines. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke, jsbell
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, jeffcarp, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support both MANIFEST.json formats and update wpt test expectations. Background: In http://crrev.com/2610243002 web-platform-tests were imported, and the Port class was updated to handle the new MANIFEST.json format. I originally believed that the new MANIFEST.json would also be committed in that CL, but it wasn't, due to file size. So tests were updated, but no tests were run because they weren't found. Then, in http://crrev.com/2615903004, the manifest was actually updated, so tests started being run, but because of the earlier CL, the newly-imported failing tests didn't have expectations updated. This CL adds a temporary change to the Port class to support both manifest formats, and updates test expectations. After this CL: - The new MANIFEST.json should be re-added. - Port should be updated to support only the new format again. BUG=678077 Review-Url: https://codereview.chromium.org/2614253003 Cr-Commit-Position: refs/heads/master@{#442354} Committed: https://chromium.googlesource.com/chromium/src/+/2cdab23afa9bf4d85db6926da0bdae66133f3212

Patch Set 1 #

Patch Set 2 : Change base to accept either old or new format. #

Patch Set 3 : Rebaseline #

Patch Set 4 : Update expectations #

Patch Set 5 : Update imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expec… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -18 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/FileAPI/reading-data-section/FileReader-multiple-reads-expected.txt View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/dom/historical-expected.txt View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-form-element/form-nameditem-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-matchAll.https-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-matchAll.https-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/Animation/finish-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/KeyframeEffect/iterationComposite-expected.txt View 1 2 3 4 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 2 3 4 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
qyearsley
3 years, 11 months ago (2017-01-07 20:08:45 UTC) #4
Dirk Pranke
lgtm
3 years, 11 months ago (2017-01-09 03:31:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614253003/20001
3 years, 11 months ago (2017-01-09 17:07:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/360038)
3 years, 11 months ago (2017-01-09 18:25:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614253003/40001
3 years, 11 months ago (2017-01-09 20:13:34 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 21:29:43 UTC) #22
Message was sent while issue was closed.
Committed patchset #5 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2cdab23afa9bf4d85db6926da0bd...

Powered by Google App Engine
This is Rietveld 408576698