Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2614213002: Finalize new UseCounter histogram names (Closed)

Created:
3 years, 11 months ago by Rick Byers
Modified:
3 years, 8 months ago
CC:
chromium-reviews, blink-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Finalize new UseCounter histogram names The new UseCounter histograms are now working well and the data we're getting looks solid. It's time to make them official as the primary histograms to track. BUG=676837 Review-Url: https://codereview.chromium.org/2614213002 Cr-Commit-Position: refs/heads/master@{#442115} Committed: https://chromium.googlesource.com/chromium/src/+/68f6cfe0bc29b69e8de3e77a21809021ba4c11ee

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -78 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +7 lines, -8 lines 2 comments Download
M third_party/WebKit/Source/core/frame/UseCounterTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 4 chunks +90 lines, -66 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Rick Byers
rkaplow: PTAL
3 years, 11 months ago (2017-01-06 21:10:04 UTC) #4
rkaplow
lgtm
3 years, 11 months ago (2017-01-06 21:20:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614213002/1
3 years, 11 months ago (2017-01-06 21:23:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/132904)
3 years, 11 months ago (2017-01-06 22:05:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614213002/1
3 years, 11 months ago (2017-01-06 22:52:47 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/68f6cfe0bc29b69e8de3e77a21809021ba4c11ee
3 years, 11 months ago (2017-01-07 00:45:30 UTC) #15
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/2614213002/diff/1/third_party/WebKit/Source/core/frame/UseCounter.cpp File third_party/WebKit/Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/2614213002/diff/1/third_party/WebKit/Source/core/frame/UseCounter.cpp#newcode1291 third_party/WebKit/Source/core/frame/UseCounter.cpp:1291: * WebCore.UseCounter This should be also updated?
3 years, 8 months ago (2017-03-27 05:54:07 UTC) #17
Rick Byers
https://codereview.chromium.org/2614213002/diff/1/third_party/WebKit/Source/core/frame/UseCounter.cpp File third_party/WebKit/Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/2614213002/diff/1/third_party/WebKit/Source/core/frame/UseCounter.cpp#newcode1291 third_party/WebKit/Source/core/frame/UseCounter.cpp:1291: * WebCore.UseCounter On 2017/03/27 05:54:07, tyoshino wrote: > This ...
3 years, 8 months ago (2017-03-27 16:24:47 UTC) #18
tyoshino (SeeGerritForStatus)
3 years, 8 months ago (2017-03-28 06:18:27 UTC) #19
Message was sent while issue was closed.
On 2017/03/27 16:24:47, Rick Byers wrote:
>
https://codereview.chromium.org/2614213002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/frame/UseCounter.cpp (right):
> 
>
https://codereview.chromium.org/2614213002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/frame/UseCounter.cpp:1291: * WebCore.UseCounter
> On 2017/03/27 05:54:07, tyoshino wrote:
> > This should be also updated?
> 
> Yep, sorry I missed that.  I'm pretty close to being able to delete that code
> entirely though (should happen in the next month or so -
> https://crbug.com/676837).  Worth me landing a separate fix for anyway do you
> think?

Oh, ok. It's totally up to you. I just notified you of that since I noticed it.

Powered by Google App Engine
This is Rietveld 408576698