Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: components/data_use_measurement/content/content_url_request_classifier.cc

Issue 2614203002: Record data use of user traffic by different core page transition types (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_use_measurement/content/content_url_request_classifier.cc
diff --git a/components/data_use_measurement/content/content_url_request_classifier.cc b/components/data_use_measurement/content/content_url_request_classifier.cc
index 23bbd8baa9624a0515bfab3b4bf2026ab5e4243a..add53965830447f297215f0e8f8d6ce4f5fe5178 100644
--- a/components/data_use_measurement/content/content_url_request_classifier.cc
+++ b/components/data_use_measurement/content/content_url_request_classifier.cc
@@ -4,8 +4,11 @@
#include "components/data_use_measurement/content/content_url_request_classifier.h"
+#include "base/metrics/histogram_macros.h"
+#include "base/metrics/sparse_histogram.h"
#include "content/public/browser/resource_request_info.h"
#include "net/url_request/url_request.h"
+#include "ui/base/page_transition_types.h"
namespace data_use_measurement {
@@ -26,4 +29,25 @@ bool ContentURLRequestClassifier::IsUserRequest(
return data_use_measurement::IsUserRequest(request);
}
+void ContentURLRequestClassifier::RecordPageTransitionUMA(
+ int32_t page_transition,
+ int64_t received_bytes) const {
+ ui::PageTransition core_page_transition = ui::PageTransitionStripQualifier(
RyanSturm 2017/01/10 18:32:23 Like I mentioned before, this shouldn't be necessa
Raj 2017/01/10 22:21:57 Done.
+ static_cast<ui::PageTransition>(page_transition));
+ if (core_page_transition > ui::PAGE_TRANSITION_LAST_CORE)
+ return;
+ if (received_bytes <= 0)
+ return;
+
+ // Use the more primitive STATIC_HISTOGRAM_POINTER_BLOCK macro because the
+ // simple UMA_HISTOGRAM_ENUMERATION macros don't expose 'AddCount'.
+ STATIC_HISTOGRAM_POINTER_BLOCK(
+ "DataUse.PageTransition.UserTraffic",
RyanSturm 2017/01/10 18:32:23 Do you need to address the issue mpearson raised o
Raj 2017/01/10 22:21:57 Its not clear whether the overflow bug should be f
+ AddCount(core_page_transition, received_bytes),
+ base::LinearHistogram::FactoryGet(
+ "DataUse.PageTransition.UserTraffic", 1,
+ ui::PAGE_TRANSITION_LAST_CORE, ui::PAGE_TRANSITION_LAST_CORE + 1,
+ base::HistogramBase::kUmaTargetedHistogramFlag));
+}
+
} // namespace data_use_measurement

Powered by Google App Engine
This is Rietveld 408576698