Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: components/data_use_measurement/core/data_use_measurement.cc

Issue 2614203002: Record data use of user traffic by different core page transition types (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_use_measurement/core/data_use_measurement.cc
diff --git a/components/data_use_measurement/core/data_use_measurement.cc b/components/data_use_measurement/core/data_use_measurement.cc
index 6508f99ade7c1e38116388d23aa7e36c89949ba4..c2a68f2f0bac3fd79e5c3b61a53f7c0305c84a11 100644
--- a/components/data_use_measurement/core/data_use_measurement.cc
+++ b/components/data_use_measurement/core/data_use_measurement.cc
@@ -143,6 +143,7 @@ void DataUseMeasurement::OnCompleted(const net::URLRequest& request,
// of redirected requests.
UpdateDataUsePrefs(request);
ReportServicesMessageSizeUMA(request);
+ RecordPageTransitionUMA(request);
#if defined(OS_ANDROID)
MaybeRecordNetworkBytesOS();
#endif
@@ -347,7 +348,7 @@ void DataUseMeasurement::RecordTabStateHistogram(
TrafficDirection dir,
DataUseUserData::AppState app_state,
bool is_tab_visible,
- int64_t bytes) {
+ int64_t bytes) const {
if (app_state == DataUseUserData::UNKNOWN)
return;
@@ -363,4 +364,19 @@ void DataUseMeasurement::RecordTabStateHistogram(
RecordUMAHistogramCount(histogram_name, bytes);
}
+void DataUseMeasurement::RecordPageTransitionUMA(
+ const net::URLRequest& request) const {
+ if (!url_request_classifier_->IsUserRequest(request))
+ return;
+
+ const DataUseRecorder* recorder = ascriber_->GetDataUseRecorder(request);
+ if (recorder) {
+ LOG(WARNING) << "DATAUSE page transition " << recorder << " " << &request
RyanSturm 2017/01/06 21:56:38 remove the log before landing.
Raj 2017/01/10 22:21:57 Done.
+ << " " << recorder->page_transition() << " "
+ << request.GetTotalReceivedBytes();
+ url_request_classifier_->RecordPageTransitionUMA(
+ recorder->page_transition(), request.GetTotalReceivedBytes());
+ }
+}
+
} // namespace data_use_measurement

Powered by Google App Engine
This is Rietveld 408576698