Use ARC_GET_INSTANCE_FOR_METHOD for getting intent_helper instance

Use ARC_GET_INSTANCE_FOR_METHOD for getting intent_helper instance

This is safer than manually specifying min versions.

BUG=649782
TEST=git try, manually tested files.app, context menu, and link click

Review-Url: https://codereview.chromium.org/2614173002
Cr-Commit-Position: refs/heads/master@{#442119}
Committed: https://chromium.googlesource.com/chromium/src/+/c725a146113b550b42700e2cf9bccdd522c25f91

[Yusuke Sato, 2017-01-06 19:20:12]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 19:20:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 20:06:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 20:06:26]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2017-01-06 23:01:23]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 23:02:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2017-01-06 23:29:55]

Description was changed from

==========
wip - not for review
BUG=
==========

to

==========
Use ARC_GET_INSTANCE_FOR_METHOD for getting intent_helper instance

This is safer than manually specifying min versions.

BUG=649782
TEST=git try, manually tested files.app, context menu, and link click
==========

[Yusuke Sato, 2017-01-06 23:29:55]

yusukes@chromium.org changed reviewers:
+ kinaba@chromium.org, lhchavez@chromium.org

[Yusuke Sato, 2017-01-06 23:30:05]

PTAL

[commit-bot: I haz the power, 2017-01-06 23:43:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 23:43:26]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2017-01-06 23:46:28]

lgtm

Thanks for doing this :D

https://codereview.chromium.org/2614173002/diff/20001/components/arc/intent_h...
File components/arc/intent_helper/activity_icon_loader.cc (right):

https://codereview.chromium.org/2614173002/diff/20001/components/arc/intent_h...
components/arc/intent_helper/activity_icon_loader.cc:38:
mojom::IntentHelperInstance* GetInstance(
Can we name this GetInstanceForRequestActivityIcons?

[kinaba, 2017-01-06 23:51:20]

filemanager lgtm

[Yusuke Sato, 2017-01-07 00:25:14]

https://codereview.chromium.org/2614173002/diff/20001/components/arc/intent_h...
File components/arc/intent_helper/activity_icon_loader.cc (right):

https://codereview.chromium.org/2614173002/diff/20001/components/arc/intent_h...
components/arc/intent_helper/activity_icon_loader.cc:38:
mojom::IntentHelperInstance* GetInstance(
On 2017/01/06 23:46:28, Luis Héctor Chávez wrote:
> Can we name this GetInstanceForRequestActivityIcons?

Done.

[Yusuke Sato, 2017-01-07 00:25:22]

The CQ bit was checked by yusukes@chromium.org

[Yusuke Sato, 2017-01-07 00:25:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org, kinaba@chromium.org
Link to the patchset: https://codereview.chromium.org/2614173002/#ps40001
(title: "address comment")

[commit-bot: I haz the power, 2017-01-07 00:25:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 00:56:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483748722451930,
"parent_rev": "005913147578ab11de32f536c7d7748df8f1d4bc", "commit_rev":
"c725a146113b550b42700e2cf9bccdd522c25f91"}

[commit-bot: I haz the power, 2017-01-07 00:56:58]

Description was changed from

==========
Use ARC_GET_INSTANCE_FOR_METHOD for getting intent_helper instance

This is safer than manually specifying min versions.

BUG=649782
TEST=git try, manually tested files.app, context menu, and link click
==========

to

==========
Use ARC_GET_INSTANCE_FOR_METHOD for getting intent_helper instance

This is safer than manually specifying min versions.

BUG=649782
TEST=git try, manually tested files.app, context menu, and link click

Review-Url: https://codereview.chromium.org/2614173002
Cr-Commit-Position: refs/heads/master@{#442119}
Committed:
https://chromium.googlesource.com/chromium/src/+/c725a146113b550b42700e2cf9bc...
==========

[commit-bot: I haz the power, 2017-01-07 00:56:59]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c725a146113b550b42700e2cf9bc...