Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2614143002: Use a new Supplement constructor for LocalFrame's supplements (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, awdf+watch_chromium.org, shalamov, tzik, Peter Beverloo, johnme+watch_chromium.org, nhiroki, haraken, tommyw+watchlist_chromium.org, cmumford, wanming.lin, blink-reviews, kinuko+watch, jsbell+idb_chromium.org, harkness+watch_chromium.org, kinuko+fileapi, mcasas+watch+mediastream_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a new Supplement constructor for LocalFrame's supplements This is one of the steps to deprecate the default constructor of Supplement. BUG=610176 Review-Url: https://codereview.chromium.org/2614143002 Cr-Commit-Position: refs/heads/master@{#441943} Committed: https://chromium.googlesource.com/chromium/src/+/4c5494ab0c4036e09b174ee9d425ba03465deb31

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -73 lines) Patch
M third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/LocalFileSystem.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp View 3 chunks +22 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IndexedDBClient.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IndexedDBClient.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaController.h View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaController.cpp View 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationController.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushController.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushController.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProviderProxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp View 2 chunks +7 lines, -10 lines 1 comment Download
M third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/AudioOutputDeviceClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/AudioOutputDeviceClientImpl.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/IndexedDBClientImpl.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/IndexedDBClientImpl.cpp View 1 chunk +12 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-06 12:45:55 UTC) #3
haraken
https://codereview.chromium.org/2614143002/diff/1/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp File third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp (left): https://codereview.chromium.org/2614143002/diff/1/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp#oldcode17 third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp:17: initialize(frame); This is not needed because it's called at ...
3 years, 11 months ago (2017-01-06 12:46:55 UTC) #5
sof
lgtm
3 years, 11 months ago (2017-01-06 13:19:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614143002/1
3 years, 11 months ago (2017-01-06 14:47:23 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 15:39:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4c5494ab0c4036e09b174ee9d425...

Powered by Google App Engine
This is Rietveld 408576698