Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2614103002: Revert of Make FTP directory parser less strict (Closed)

Created:
3 years, 11 months ago by loyso (OOO)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr.
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make FTP directory parser less strict (patchset #3 id:40001 of https://codereview.chromium.org/2608213002/ ) Reason for revert: Fails on all platforms. https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%281%29/builds/62042 Original issue's description: > Make FTP directory parser less strict > > FTP directory listing returns empty result if encoding detection or > conversion fails. This CL puts less strict constraint on conversion > so that the whole list can survive some filenames with broken chars > and be shown to users. Other browsers seem to work this way. > > The broken chars can happen due to wrong encoding detection, which > cannot be avoided 100%, as reported in the bug. > > BUG=676762 > R=mmenke@chromium.org, phajdan.jr@chromium.org > > Review-Url: https://codereview.chromium.org/2608213002 . > Cr-Commit-Position: refs/heads/master@{#441856} > Committed: https://chromium.googlesource.com/chromium/src/+/ed3ef90ecc3c01246a3d838fbeefdab72c94c228 TBR=phajdan.jr@chromium.org,mmenke@chromium.org,jinsukkim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=676762 Review-Url: https://codereview.chromium.org/2614103002 Cr-Commit-Position: refs/heads/master@{#441866} Committed: https://chromium.googlesource.com/chromium/src/+/9c484365968491ca416461d7c982aca155ff26bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -22 lines) Patch
D net/data/ftp/dir-listing-ls-34 View 1 chunk +0 lines, -2 lines 0 comments Download
D net/data/ftp/dir-listing-ls-34.expected View 1 chunk +0 lines, -17 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
loyso (OOO)
Created Revert of Make FTP directory parser less strict
3 years, 11 months ago (2017-01-06 03:57:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614103002/1
3 years, 11 months ago (2017-01-06 03:57:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9c484365968491ca416461d7c982aca155ff26bf
3 years, 11 months ago (2017-01-06 03:58:59 UTC) #6
mmenke
3 years, 11 months ago (2017-01-06 04:02:26 UTC) #7
Message was sent while issue was closed.
And for those viewing at home, a sample failure that is open source: 
https://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.9%20Tests...

Powered by Google App Engine
This is Rietveld 408576698