Cleanup RangeCheck class and dependencies

Cleanup RangeCheck class and dependencies

Moves the test code out of RangeCheck. Reorders range comparisons and
removes bitfields to avoid a GCC constexpr bug. Removes some custom
optimizations that are no longer necessary after the restructuring.

TBR=tsepez

Review-Url: https://codereview.chromium.org/2614073002
Cr-Commit-Position: refs/heads/master@{#441921}
Committed: https://chromium.googlesource.com/chromium/src/+/082b2bad6a2b060d8daf01bcd13ccda7708a77c2

[jschuh, 2017-01-05 23:38:05]

Description was changed from

==========
Move test logic out of numeric RangeCheck class
==========

to

==========
Move test logic out of numeric RangeCheck class

TBR=tsepez
==========

[jschuh, 2017-01-05 23:38:06]

jschuh@chromium.org changed reviewers:
+ tsepez@chromium.org

[jschuh, 2017-01-06 00:05:04]

The CQ bit was checked by jschuh@chromium.org

[commit-bot: I haz the power, 2017-01-06 00:05:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 00:28:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 00:28:33]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jschuh, 2017-01-06 04:41:43]

Reordering the comparisons made the bitfields unnecessary as an optimization.
So, I removed them to fix the GCC crash on constexpr bitfields.

[jschuh, 2017-01-06 04:43:11]

Description was changed from

==========
Move test logic out of numeric RangeCheck class

TBR=tsepez
==========

to

==========
Move test logic out of numeric RangeCheck class

Reorders range comparisons and removes bitfields to avoid a GCC bug.

TBR=tsepez
==========

[jschuh, 2017-01-06 05:42:31]

And it turns out that my clever integer specialization isn't needed on clang
anymore either after reordering the comparisons. It still helps a bit on GCC,
but we don't ship with GCC anymore.

[jschuh, 2017-01-06 05:48:06]

Description was changed from

==========
Move test logic out of numeric RangeCheck class

Reorders range comparisons and removes bitfields to avoid a GCC bug.

TBR=tsepez
==========

to

==========
Cleanup RangeCheck class and dependencies

Moves the test code out of RangeCheck. Reorders range comparisons and
removes bitfields to avoid a GCC constexpr bug. Removes some custom
optimizations that are no longer necessary after the restructuring.

TBR=tsepez
==========

[jschuh, 2017-01-06 09:44:30]

The CQ bit was checked by jschuh@chromium.org

[commit-bot: I haz the power, 2017-01-06 09:44:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 11:40:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483695870140480,
"parent_rev": "5251d861c9ec23ba5d3205582b7904eac64f3d1b", "commit_rev":
"082b2bad6a2b060d8daf01bcd13ccda7708a77c2"}

[commit-bot: I haz the power, 2017-01-06 11:41:25]

Description was changed from

==========
Cleanup RangeCheck class and dependencies

Moves the test code out of RangeCheck. Reorders range comparisons and
removes bitfields to avoid a GCC constexpr bug. Removes some custom
optimizations that are no longer necessary after the restructuring.

TBR=tsepez
==========

to

==========
Cleanup RangeCheck class and dependencies

Moves the test code out of RangeCheck. Reorders range comparisons and
removes bitfields to avoid a GCC constexpr bug. Removes some custom
optimizations that are no longer necessary after the restructuring.

TBR=tsepez

Review-Url: https://codereview.chromium.org/2614073002
Cr-Commit-Position: refs/heads/master@{#441921}
Committed:
https://chromium.googlesource.com/chromium/src/+/082b2bad6a2b060d8daf01bcd13c...
==========

[commit-bot: I haz the power, 2017-01-06 11:41:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/082b2bad6a2b060d8daf01bcd13c...

[Tom Sepez, 2017-01-06 17:09:41]

lgtm