Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2614033004: Convert SetContentSettingRules to use mojo, part 2/2. (Closed)

Created:
3 years, 11 months ago by nigeltao1
Modified:
3 years, 11 months ago
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert SetContentSettingRules to use mojo, part 2/2. This converts the remaining ChromeViewMsg_SetContentSettingRules uses. The previous commit was https://codereview.chromium.org/2582203003 BUG=577685 Review-Url: https://codereview.chromium.org/2614033004 Cr-Commit-Position: refs/heads/master@{#444628} Committed: https://chromium.googlesource.com/chromium/src/+/825a6e9f4965ebc343bc3b628e2f089033a6607d

Patch Set 1 #

Patch Set 2 : Convert SetContentSettingRules to use mojo, part 2/2. #

Patch Set 3 : Convert SetContentSettingRules to use mojo, part 2/2. #

Patch Set 4 : Convert SetContentSettingRules to use mojo, part 2/2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -171 lines) Patch
M chrome/browser/content_settings/tab_specific_content_settings.cc View 1 3 chunks +11 lines, -2 lines 0 comments Download
M chrome/common/BUILD.gn View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/common_param_traits_macros.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/common/content_settings_pattern_serializer.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/common/content_settings_pattern_serializer.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 3 3 chunks +0 lines, -44 lines 0 comments Download
D chrome/common/render_messages.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/renderer/chrome_render_thread_observer.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_render_thread_observer.cc View 1 2 3 4 chunks +2 lines, -9 lines 0 comments Download
M components/content_settings/core/common/content_settings_pattern.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 48 (29 generated)
nigeltao1
3 years, 11 months ago (2017-01-06 04:41:13 UTC) #2
Sam McNally
lgtm
3 years, 11 months ago (2017-01-06 05:23:18 UTC) #5
nigeltao1
R=sky for OWNERS
3 years, 11 months ago (2017-01-13 04:00:34 UTC) #17
sky
LGTM
3 years, 11 months ago (2017-01-13 15:22:41 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614033004/40001
3 years, 11 months ago (2017-01-14 00:35:06 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/342191)
3 years, 11 months ago (2017-01-14 00:42:14 UTC) #23
nigeltao1
R=tsepez for OWNERS.
3 years, 11 months ago (2017-01-14 00:47:31 UTC) #25
nigeltao1
tsepez: ping.
3 years, 11 months ago (2017-01-17 11:55:25 UTC) #26
Tom Sepez
lgtm
3 years, 11 months ago (2017-01-17 18:55:09 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614033004/40001
3 years, 11 months ago (2017-01-17 23:00:50 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/22496) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-17 23:04:41 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614033004/40001
3 years, 11 months ago (2017-01-18 11:53:44 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/137592) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-18 11:55:39 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614033004/60001
3 years, 11 months ago (2017-01-18 23:55:08 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/344788)
3 years, 11 months ago (2017-01-19 00:03:57 UTC) #40
nigeltao1
R=raymes for OWNERS for a trivial change to components/content_settings/core/common/content_settings_pattern.h
3 years, 11 months ago (2017-01-19 01:58:21 UTC) #42
raymes
lgtm
3 years, 11 months ago (2017-01-19 02:42:13 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614033004/60001
3 years, 11 months ago (2017-01-19 03:41:02 UTC) #45
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 03:46:30 UTC) #48
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/825a6e9f4965ebc343bc3b628e2f...

Powered by Google App Engine
This is Rietveld 408576698