Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2614023005: Revert of Add an experimental standalone content suggestions UI. (Closed)

Created:
3 years, 11 months ago by dewittj
Modified:
3 years, 11 months ago
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add an experimental standalone content suggestions UI. (patchset #8 id:140001 of https://codereview.chromium.org/2593523005/ ) Reason for revert: Speculative revert, likely broke: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/38814 However, there appears to be logdog problems, so I'm not sure if we are getting realistic error messages. E 1343.751s run_tests_on_device(07601d750ae534e5) Error not bootstrapped. Failed to start logdog: Missing project [LOGDOG_STREAM_PROJECT] Traceback (most recent call last): File "/b/s/w/irq8DwmG/build/android/pylib/android/logdog_logcat_monitor.py", line 28, in __init__ self._stream_client = bootstrap.ButlerBootstrap.probe().stream_client() File "/b/s/w/irq8DwmG/tools/swarming_client/libs/logdog/bootstrap.py", line 48, in probe raise NotBootstrappedError('Missing project [%s]' % (cls._ENV_PROJECT,)) NotBootstrappedError: Missing project [LOGDOG_STREAM_PROJECT] Original issue's description: > Add an experimental standalone content suggestions UI. > > The UI is hidden behind a feature flag that enables a menu item (which > uses innovative string compression techniques to avoid bloat due to > i18n) to open the standalone content suggestions UI. > > While the activity and menu item are not meant to be shipped in an > enabled state, this will allow iterating on a content suggestions UI > outside of the NTP. > > Review-Url: https://codereview.chromium.org/2593523005 > Cr-Commit-Position: refs/heads/master@{#441980} > Committed: https://chromium.googlesource.com/chromium/src/+/1b34593a53181b7f8a06a97206219c16486b33a1 TBR=mvanouwerkerk@chromium.org,dgn@chromium.org,bauerb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2614023005 Cr-Commit-Position: refs/heads/master@{#442068} Committed: https://chromium.googlesource.com/chromium/src/+/0f17a6c232f6e4df227e3e149c6b097957151276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -284 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/java/res/menu/main_menu.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java View 4 chunks +12 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 chunk +2 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java View 7 chunks +11 lines, -29 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java View 1 chunk +0 lines, -202 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/suggestions/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dewittj
Created Revert of Add an experimental standalone content suggestions UI.
3 years, 11 months ago (2017-01-06 21:53:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614023005/1
3 years, 11 months ago (2017-01-06 21:53:55 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 21:55:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f17a6c232f6e4df227e3e149c6b...

Powered by Google App Engine
This is Rietveld 408576698