Preparsing inner funcs: Update tests.

Preparsing inner funcs: Update tests.

1) Fix confusion between for of and for in.

2) If a for loop doesn't declare its variables, no new variables
are introduced (the outer scope variables are used).

3) Add more cases for destructuring for and destructuring catch.


BUG=v8:5501, v8:5516
Review-Url: https://codereview.chromium.org/2614023004
Cr-Commit-Position: refs/heads/master@{#42125}
Committed: https://chromium.googlesource.com/v8/v8/+/bd62841eb9ba58d7aaf5c06d718ec05b7fefe2bc

[marja, 2017-01-06 11:55:27]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 11:55:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2017-01-06 11:56:24]

Description was changed from

==========
Preparsing inner funcs: Update tests.

1) Fix confusion between for of and for in.

2) If a for loop doesn't declare its variables, no new variables
are introduced (the outer scope variables are used).

3) Add more cases for destructuring for and destructuring catch.

BUG=v8:5501, v8:5516
==========

to

==========
Preparsing inner funcs: Update tests.

1) Fix confusion between for of and for in.

2) If a for loop doesn't declare its variables, no new variables
are introduced (the outer scope variables are used).

3) Add more cases for destructuring for and destructuring catch.

4) Add more cases where the arrow function is inside the inner function
(and thus the params are preparsed)

BUG=v8:5501, v8:5516
==========

[marja, 2017-01-06 11:56:24]

marja@chromium.org changed reviewers:
+ adamk@chromium.org

[marja, 2017-01-06 11:57:41]

Description was changed from

==========
Preparsing inner funcs: Update tests.

1) Fix confusion between for of and for in.

2) If a for loop doesn't declare its variables, no new variables
are introduced (the outer scope variables are used).

3) Add more cases for destructuring for and destructuring catch.

4) Add more cases where the arrow function is inside the inner function
(and thus the params are preparsed)

BUG=v8:5501, v8:5516
==========

to

==========
Preparsing inner funcs: Update tests.

1) Fix confusion between for of and for in.

2) If a for loop doesn't declare its variables, no new variables
are introduced (the outer scope variables are used).

3) Add more cases for destructuring for and destructuring catch.


BUG=v8:5501, v8:5516
==========

[marja, 2017-01-06 11:57:47]

adamk, ptal

[commit-bot: I haz the power, 2017-01-06 12:19:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 12:19:05]

Dry run: This issue passed the CQ dry run.

[adamk, 2017-01-06 18:58:28]

lgtm

Love having this level of test coverage, thanks!

[marja, 2017-01-09 08:26:32]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2017-01-09 08:26:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 08:53:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483950392145980, "parent_rev":
"65537684b6c07b0cb7aee94b06b6e582214f992f", "commit_rev":
"bd62841eb9ba58d7aaf5c06d718ec05b7fefe2bc"}

[commit-bot: I haz the power, 2017-01-09 08:53:18]

Description was changed from

==========
Preparsing inner funcs: Update tests.

1) Fix confusion between for of and for in.

2) If a for loop doesn't declare its variables, no new variables
are introduced (the outer scope variables are used).

3) Add more cases for destructuring for and destructuring catch.


BUG=v8:5501, v8:5516
==========

to

==========
Preparsing inner funcs: Update tests.

1) Fix confusion between for of and for in.

2) If a for loop doesn't declare its variables, no new variables
are introduced (the outer scope variables are used).

3) Add more cases for destructuring for and destructuring catch.


BUG=v8:5501, v8:5516

Review-Url: https://codereview.chromium.org/2614023004
Cr-Commit-Position: refs/heads/master@{#42125}
Committed:
https://chromium.googlesource.com/v8/v8/+/bd62841eb9ba58d7aaf5c06d718ec05b7fe...
==========

[commit-bot: I haz the power, 2017-01-09 08:53:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/bd62841eb9ba58d7aaf5c06d718ec05b7fe...