Whitelist extension used by autotest to use networkingPrivate.

Whitelist extension used by autotest to use networkingPrivate.

BUG=672340
Review-Url: https://codereview.chromium.org/2614023003
Cr-Commit-Position: refs/heads/master@{#442645}
Committed: https://chromium.googlesource.com/chromium/src/+/a6e8cd6a118d18cef16398294ca5b44e6f723dff

[harpreet1, 2017-01-05 22:27:08]

Description was changed from

==========
Whitelist extension used by autotest to use networkingPrivate.

BUG=678780
==========

to

==========
Whitelist extension used by autotest to use networkingPrivate.

BUG=678780
==========

[harpreet1, 2017-01-05 22:27:08]

harpreet@chromium.org changed reviewers:
+ achuith@chromium.org, xiyuan@chromium.org

[xiyuan, 2017-01-05 22:28:54]

lgtm

Think you need an extension owner to stamp on the CL as well.

[harpreet1, 2017-01-05 22:30:56]

harpreet@chromium.org changed reviewers:
+ stevenjb@chromium.org

[harpreet1, 2017-01-05 22:32:18]

harpreet@chromium.org changed reviewers:
+ tbarzic@chromium.org

[stevenjb, 2017-01-05 22:33:26]

lgtm

[achuithb, 2017-01-05 22:33:29]

Why is bug 678780 marked Fixed?

https://codereview.chromium.org/2614023003/diff/1/extensions/common/api/_perm...
File extensions/common/api/_permission_features.json (right):

https://codereview.chromium.org/2614023003/diff/1/extensions/common/api/_perm...
extensions/common/api/_permission_features.json:335:
"23D8847AE3EE90122AA34657360AFEEC8B3E611B",  // Autotest
Shouldn't this be in networkingPrivate?

[achuithb, 2017-01-05 22:35:28]

I assume you were able to locally verify that this works?

lgtm if so

https://codereview.chromium.org/2614023003/diff/1/extensions/common/api/_perm...
File extensions/common/api/_permission_features.json (right):

https://codereview.chromium.org/2614023003/diff/1/extensions/common/api/_perm...
extensions/common/api/_permission_features.json:352: // networkingPrivate is
being migrated to networking.onc.
Ok, nm, just saw this

[harpreet1, 2017-01-05 22:42:53]

On 2017/01/05 22:35:28, achuithb wrote:
> I assume you were able to locally verify that this works?
I have not verified it locally. What is the process here? Should I leave
crbug.com/678780 open for now and submit this CL and check if crbug.com/672340
gets resolved over the next couple days (if nightly run's start passing) before
marking it as fixed?

> 
> lgtm if so
> 
>
https://codereview.chromium.org/2614023003/diff/1/extensions/common/api/_perm...
> File extensions/common/api/_permission_features.json (right):
> 
>
https://codereview.chromium.org/2614023003/diff/1/extensions/common/api/_perm...
> extensions/common/api/_permission_features.json:352: // networkingPrivate is
> being migrated to networking.onc.
> Ok, nm, just saw this

[achuithb, 2017-01-05 22:46:55]

On 2017/01/05 22:42:53, harpreet1 wrote:
> On 2017/01/05 22:35:28, achuithb wrote:
> > I assume you were able to locally verify that this works?
> I have not verified it locally. What is the process here? Should I leave
> crbug.com/678780 open for now and submit this CL and check if crbug.com/672340
> gets resolved over the next couple days (if nightly run's start passing)
before
> marking it as fixed?
> 

I'll not lgtm this for now since we don't want to land a speculative change.

You need to use the simple chrome flow to build a TOT chrome build with this fix
locally, deploy this chrome to your DUT, and run the failing autotest on the DUT
to ensure that it passes. You should explicitly verify that reverting this CL
locally and deploying your local chrome will cause the autotest to fail.

[harpreet1, 2017-01-05 22:50:52]

On 2017/01/05 22:46:55, achuithb wrote:
> On 2017/01/05 22:42:53, harpreet1 wrote:
> > On 2017/01/05 22:35:28, achuithb wrote:
> > > I assume you were able to locally verify that this works?
> > I have not verified it locally. What is the process here? Should I leave
> > crbug.com/678780 open for now and submit this CL and check if
crbug.com/672340
> > gets resolved over the next couple days (if nightly run's start passing)
> before
> > marking it as fixed?
> > 
> 
> I'll not lgtm this for now since we don't want to land a speculative change.
> 
> You need to use the simple chrome flow to build a TOT chrome build with this
fix
> locally, deploy this chrome to your DUT, and run the failing autotest on the
DUT
> to ensure that it passes. You should explicitly verify that reverting this CL
> locally and deploying your local chrome will cause the autotest to fail.

Is there step-by-step guide to build chrome? Haven't done this before.

[achuithb, 2017-01-05 22:57:22]

On 2017/01/05 22:50:52, harpreet1 wrote:
> On 2017/01/05 22:46:55, achuithb wrote:
> > On 2017/01/05 22:42:53, harpreet1 wrote:
> > > On 2017/01/05 22:35:28, achuithb wrote:
> > > > I assume you were able to locally verify that this works?
> > > I have not verified it locally. What is the process here? Should I leave
> > > crbug.com/678780 open for now and submit this CL and check if
> crbug.com/672340
> > > gets resolved over the next couple days (if nightly run's start passing)
> > before
> > > marking it as fixed?
> > > 
> > 
> > I'll not lgtm this for now since we don't want to land a speculative change.
> > 
> > You need to use the simple chrome flow to build a TOT chrome build with this
> fix
> > locally, deploy this chrome to your DUT, and run the failing autotest on the
> DUT
> > to ensure that it passes. You should explicitly verify that reverting this
CL
> > locally and deploying your local chrome will cause the autotest to fail.
> 
> Is there step-by-step guide to build chrome? Haven't done this before.

https://www.chromium.org/chromium-os/how-tos-and-troubleshooting/building-chr...

[tbarzic, 2017-01-05 23:26:51]

https://codereview.chromium.org/2614023003/diff/1/extensions/common/api/_perm...
File extensions/common/api/_permission_features.json (right):

https://codereview.chromium.org/2614023003/diff/1/extensions/common/api/_perm...
extensions/common/api/_permission_features.json:352: // networkingPrivate is
being migrated to networking.onc.
On 2017/01/05 22:35:28, achuithb wrote:
> Ok, nm, just saw this

Though, I think this still needs networkingPrivate permission.
Unless the test app is update to use networking.onc.

[achuithb, 2017-01-05 23:45:36]

On 2017/01/05 23:26:51, tbarzic wrote:
>
https://codereview.chromium.org/2614023003/diff/1/extensions/common/api/_perm...
> File extensions/common/api/_permission_features.json (right):
> 
>
https://codereview.chromium.org/2614023003/diff/1/extensions/common/api/_perm...
> extensions/common/api/_permission_features.json:352: // networkingPrivate is
> being migrated to networking.onc.
> On 2017/01/05 22:35:28, achuithb wrote:
> > Ok, nm, just saw this
> 
> Though, I think this still needs networkingPrivate permission.
> Unless the test app is update to use networking.onc.

I don't think it is:
https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/cli...

So I think we do need to whitelist networkingPrivate until we switch the
autotest over to using onc.

Btw, why is this CL not referencing the open bug 672340 which has details of the
failing test, instead of 678780?

[harpreet1, 2017-01-06 01:07:01]

Description was changed from

==========
Whitelist extension used by autotest to use networkingPrivate.

BUG=678780
==========

to

==========
Whitelist extension used by autotest to use networkingPrivate.

BUG=672340
==========

[harpreet1, 2017-01-06 01:23:52]

On 2017/01/05 23:45:36, achuithb wrote:
> On 2017/01/05 23:26:51, tbarzic wrote:
> >
>
https://codereview.chromium.org/2614023003/diff/1/extensions/common/api/_perm...
> > File extensions/common/api/_permission_features.json (right):
> > 
> >
>
https://codereview.chromium.org/2614023003/diff/1/extensions/common/api/_perm...
> > extensions/common/api/_permission_features.json:352: // networkingPrivate is
> > being migrated to networking.onc.
> > On 2017/01/05 22:35:28, achuithb wrote:
> > > Ok, nm, just saw this
> > 
> > Though, I think this still needs networkingPrivate permission.
> > Unless the test app is update to use networking.onc.
> 
> I don't think it is:
>
https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/cli...
> 
> So I think we do need to whitelist networkingPrivate until we switch the
> autotest over to using onc.
To get it to work with networking.onc is it the following change to
background.js?
:%s/networkingPrivate/networking.onc/g

i.e. 
chrome.networkingPrivate.createNetwork  ->  chrome.networking.onc.createNetwork
chrome.networkingPrivate.setProperties  ->  chrome.networking.onc.setProperties
.
.
etc.

Anything else to be changed?

> 
> Btw, why is this CL not referencing the open bug 672340 which has details of
the
> failing test, instead of 678780?
Fixed.

[tbarzic, 2017-01-06 02:51:04]

On 2017/01/06 01:23:52, harpreet1 wrote:
> On 2017/01/05 23:45:36, achuithb wrote:
> > On 2017/01/05 23:26:51, tbarzic wrote:
> > >
> >
>
https://codereview.chromium.org/2614023003/diff/1/extensions/common/api/_perm...
> > > File extensions/common/api/_permission_features.json (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2614023003/diff/1/extensions/common/api/_perm...
> > > extensions/common/api/_permission_features.json:352: // networkingPrivate
is
> > > being migrated to networking.onc.
> > > On 2017/01/05 22:35:28, achuithb wrote:
> > > > Ok, nm, just saw this
> > > 
> > > Though, I think this still needs networkingPrivate permission.
> > > Unless the test app is update to use networking.onc.
> > 
> > I don't think it is:
> >
>
https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/cli...
> > 
> > So I think we do need to whitelist networkingPrivate until we switch the
> > autotest over to using onc.
> To get it to work with networking.onc is it the following change to
> background.js?
> :%s/networkingPrivate/networking.onc/g
> 
> i.e. 
> chrome.networkingPrivate.createNetwork  -> 
chrome.networking.onc.createNetwork
> chrome.networkingPrivate.setProperties  -> 
chrome.networking.onc.setProperties
> .
> .
> etc.
> 
> Anything else to be changed?
> 

Test extension manifest permission.

> > 
> > Btw, why is this CL not referencing the open bug 672340 which has details of
> the
> > failing test, instead of 678780?
> Fixed.

[harpreet1, 2017-01-06 19:16:37]

On 2017/01/05 22:57:22, achuithb wrote:
> On 2017/01/05 22:50:52, harpreet1 wrote:
> > On 2017/01/05 22:46:55, achuithb wrote:
> > > On 2017/01/05 22:42:53, harpreet1 wrote:
> > > > On 2017/01/05 22:35:28, achuithb wrote:
> > > > > I assume you were able to locally verify that this works?
> > > > I have not verified it locally. What is the process here? Should I leave
> > > > crbug.com/678780 open for now and submit this CL and check if
> > crbug.com/672340
> > > > gets resolved over the next couple days (if nightly run's start passing)
> > > before
> > > > marking it as fixed?
> > > > 
> > > 
> > > I'll not lgtm this for now since we don't want to land a speculative
change.
> > > 
> > > You need to use the simple chrome flow to build a TOT chrome build with
this
> > fix
> > > locally, deploy this chrome to your DUT, and run the failing autotest on
the
> > DUT
> > > to ensure that it passes. You should explicitly verify that reverting this
> CL
> > > locally and deploying your local chrome will cause the autotest to fail.
> > 
> > Is there step-by-step guide to build chrome? Haven't done this before.
> 
>
https://www.chromium.org/chromium-os/how-tos-and-troubleshooting/building-chr...

How do I fix this?

harpreet@harpreet:~/chromium/src$ cros chrome-sdk --board=panther
11:15:33: ERROR: cros chrome-sdk failed before completing.
11:15:33: ERROR: 'GYP_DEFINES'

[stevenjb, 2017-01-06 19:23:29]

Is your depot_tools up to date? What does 'which cros' say?

There shouldn't be any references to GYP_DEFINES in chromite any more.


On Fri, Jan 6, 2017 at 12:16 PM, <harpreet@chromium.org> wrote:

> On 2017/01/05 22:57:22, achuithb wrote:
> > On 2017/01/05 22:50:52, harpreet1 wrote:
> > > On 2017/01/05 22:46:55, achuithb wrote:
> > > > On 2017/01/05 22:42:53, harpreet1 wrote:
> > > > > On 2017/01/05 22:35:28, achuithb wrote:
> > > > > > I assume you were able to locally verify that this works?
> > > > > I have not verified it locally. What is the process here? Should I
> leave
> > > > > crbug.com/678780 open for now and submit this CL and check if
> > > crbug.com/672340
> > > > > gets resolved over the next couple days (if nightly run's start
> passing)
> > > > before
> > > > > marking it as fixed?
> > > > >
> > > >
> > > > I'll not lgtm this for now since we don't want to land a speculative
> change.
> > > >
> > > > You need to use the simple chrome flow to build a TOT chrome build
> with
> this
> > > fix
> > > > locally, deploy this chrome to your DUT, and run the failing
> autotest on
> the
> > > DUT
> > > > to ensure that it passes. You should explicitly verify that
> reverting this
> > CL
> > > > locally and deploying your local chrome will cause the autotest to
> fail.
> > >
> > > Is there step-by-step guide to build chrome? Haven't done this before.
> >
> >
> https://www.chromium.org/chromium-os/how-tos-and-troubleshooting/building-
> chromium-browser
>
> How do I fix this?
>
> harpreet@harpreet:~/chromium/src$ cros chrome-sdk --board=panther
> 11:15:33: ERROR: cros chrome-sdk failed before completing.
> 11:15:33: ERROR: 'GYP_DEFINES'
>
>
>
> https://codereview.chromium.org/2614023003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2017-01-06 19:43:01]

harpreet@harpreet:~/chromium$ which cros
/usr/local/google/home/harpreet/chromiumos/depot_tools/cros

cros points to my chromiumos depot tools. My chromium source is under
/usr/local/google/home/harpreet/chromium/src/



On Fri, Jan 6, 2017 at 11:23 AM, Steven Bennetts <stevenjb@chromium.org>
wrote:

> Is your depot_tools up to date? What does 'which cros' say?
>
> There shouldn't be any references to GYP_DEFINES in chromite any more.
>
>
> On Fri, Jan 6, 2017 at 12:16 PM, <harpreet@chromium.org> wrote:
>
>> On 2017/01/05 22:57:22, achuithb wrote:
>> > On 2017/01/05 22:50:52, harpreet1 wrote:
>> > > On 2017/01/05 22:46:55, achuithb wrote:
>> > > > On 2017/01/05 22:42:53, harpreet1 wrote:
>> > > > > On 2017/01/05 22:35:28, achuithb wrote:
>> > > > > > I assume you were able to locally verify that this works?
>> > > > > I have not verified it locally. What is the process here? Should
>> I leave
>> > > > > crbug.com/678780 open for now and submit this CL and check if
>> > > crbug.com/672340
>> > > > > gets resolved over the next couple days (if nightly run's start
>> passing)
>> > > > before
>> > > > > marking it as fixed?
>> > > > >
>> > > >
>> > > > I'll not lgtm this for now since we don't want to land a speculative
>> change.
>> > > >
>> > > > You need to use the simple chrome flow to build a TOT chrome build
>> with
>> this
>> > > fix
>> > > > locally, deploy this chrome to your DUT, and run the failing
>> autotest on
>> the
>> > > DUT
>> > > > to ensure that it passes. You should explicitly verify that
>> reverting this
>> > CL
>> > > > locally and deploying your local chrome will cause the autotest to
>> fail.
>> > >
>> > > Is there step-by-step guide to build chrome? Haven't done this before.
>> >
>> >
>> https://www.chromium.org/chromium-os/how-tos-and-troubleshoo
>> ting/building-chromium-browser
>>
>> How do I fix this?
>>
>> harpreet@harpreet:~/chromium/src$ cros chrome-sdk --board=panther
>> 11:15:33: ERROR: cros chrome-sdk failed before completing.
>> 11:15:33: ERROR: 'GYP_DEFINES'
>>
>>
>>
>> https://codereview.chromium.org/2614023003/
>>
>
>


-- 
h

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[stevenjb, 2017-01-06 19:47:41]

That's an unusual location for depot_tools, but should be fine. depot_tools
should auto update, so I don't know what might be wrong. Maybe try a fresh
depot_tools checkout elsewhere?


On Fri, Jan 6, 2017 at 12:42 PM, Harpreet Grewal <harpreet@google.com>
wrote:

> harpreet@harpreet:~/chromium$ which cros
> /usr/local/google/home/harpreet/chromiumos/depot_tools/cros
>
> cros points to my chromiumos depot tools. My chromium source is under
> /usr/local/google/home/harpreet/chromium/src/
>
>
>
> On Fri, Jan 6, 2017 at 11:23 AM, Steven Bennetts <stevenjb@chromium.org>
> wrote:
>
>> Is your depot_tools up to date? What does 'which cros' say?
>>
>> There shouldn't be any references to GYP_DEFINES in chromite any more.
>>
>>
>> On Fri, Jan 6, 2017 at 12:16 PM, <harpreet@chromium.org> wrote:
>>
>>> On 2017/01/05 22:57:22, achuithb wrote:
>>> > On 2017/01/05 22:50:52, harpreet1 wrote:
>>> > > On 2017/01/05 22:46:55, achuithb wrote:
>>> > > > On 2017/01/05 22:42:53, harpreet1 wrote:
>>> > > > > On 2017/01/05 22:35:28, achuithb wrote:
>>> > > > > > I assume you were able to locally verify that this works?
>>> > > > > I have not verified it locally. What is the process here? Should
>>> I leave
>>> > > > > crbug.com/678780 open for now and submit this CL and check if
>>> > > crbug.com/672340
>>> > > > > gets resolved over the next couple days (if nightly run's start
>>> passing)
>>> > > > before
>>> > > > > marking it as fixed?
>>> > > > >
>>> > > >
>>> > > > I'll not lgtm this for now since we don't want to land a
>>> speculative
>>> change.
>>> > > >
>>> > > > You need to use the simple chrome flow to build a TOT chrome build
>>> with
>>> this
>>> > > fix
>>> > > > locally, deploy this chrome to your DUT, and run the failing
>>> autotest on
>>> the
>>> > > DUT
>>> > > > to ensure that it passes. You should explicitly verify that
>>> reverting this
>>> > CL
>>> > > > locally and deploying your local chrome will cause the autotest to
>>> fail.
>>> > >
>>> > > Is there step-by-step guide to build chrome? Haven't done this
>>> before.
>>> >
>>> >
>>> https://www.chromium.org/chromium-os/how-tos-and-troubleshoo
>>> ting/building-chromium-browser
>>>
>>> How do I fix this?
>>>
>>> harpreet@harpreet:~/chromium/src$ cros chrome-sdk --board=panther
>>> 11:15:33: ERROR: cros chrome-sdk failed before completing.
>>> 11:15:33: ERROR: 'GYP_DEFINES'
>>>
>>>
>>>
>>> https://codereview.chromium.org/2614023003/
>>>
>>
>>
>
>
> --
> h
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2017-01-06 22:10:55]

Achuith, see
https://bugs.chromium.org/p/chromium/issues/detail?id=672340#c20 the fix
works as expected. Please lgtm.

On Fri, Jan 6, 2017 at 11:47 AM, Steven Bennetts <stevenjb@chromium.org>
wrote:

> That's an unusual location for depot_tools, but should be fine.
> depot_tools should auto update, so I don't know what might be wrong. Maybe
> try a fresh depot_tools checkout elsewhere?
>
>
> On Fri, Jan 6, 2017 at 12:42 PM, Harpreet Grewal <harpreet@google.com>
> wrote:
>
>> harpreet@harpreet:~/chromium$ which cros
>> /usr/local/google/home/harpreet/chromiumos/depot_tools/cros
>>
>> cros points to my chromiumos depot tools. My chromium source is under
>> /usr/local/google/home/harpreet/chromium/src/
>>
>>
>>
>> On Fri, Jan 6, 2017 at 11:23 AM, Steven Bennetts <stevenjb@chromium.org>
>> wrote:
>>
>>> Is your depot_tools up to date? What does 'which cros' say?
>>>
>>> There shouldn't be any references to GYP_DEFINES in chromite any more.
>>>
>>>
>>> On Fri, Jan 6, 2017 at 12:16 PM, <harpreet@chromium.org> wrote:
>>>
>>>> On 2017/01/05 22:57:22, achuithb wrote:
>>>> > On 2017/01/05 22:50:52, harpreet1 wrote:
>>>> > > On 2017/01/05 22:46:55, achuithb wrote:
>>>> > > > On 2017/01/05 22:42:53, harpreet1 wrote:
>>>> > > > > On 2017/01/05 22:35:28, achuithb wrote:
>>>> > > > > > I assume you were able to locally verify that this works?
>>>> > > > > I have not verified it locally. What is the process here?
>>>> Should I leave
>>>> > > > > crbug.com/678780 open for now and submit this CL and check if
>>>> > > crbug.com/672340
>>>> > > > > gets resolved over the next couple days (if nightly run's start
>>>> passing)
>>>> > > > before
>>>> > > > > marking it as fixed?
>>>> > > > >
>>>> > > >
>>>> > > > I'll not lgtm this for now since we don't want to land a
>>>> speculative
>>>> change.
>>>> > > >
>>>> > > > You need to use the simple chrome flow to build a TOT chrome
>>>> build with
>>>> this
>>>> > > fix
>>>> > > > locally, deploy this chrome to your DUT, and run the failing
>>>> autotest on
>>>> the
>>>> > > DUT
>>>> > > > to ensure that it passes. You should explicitly verify that
>>>> reverting this
>>>> > CL
>>>> > > > locally and deploying your local chrome will cause the autotest
>>>> to fail.
>>>> > >
>>>> > > Is there step-by-step guide to build chrome? Haven't done this
>>>> before.
>>>> >
>>>> >
>>>> https://www.chromium.org/chromium-os/how-tos-and-troubleshoo
>>>> ting/building-chromium-browser
>>>>
>>>> How do I fix this?
>>>>
>>>> harpreet@harpreet:~/chromium/src$ cros chrome-sdk --board=panther
>>>> 11:15:33: ERROR: cros chrome-sdk failed before completing.
>>>> 11:15:33: ERROR: 'GYP_DEFINES'
>>>>
>>>>
>>>>
>>>> https://codereview.chromium.org/2614023003/
>>>>
>>>
>>>
>>
>>
>> --
>> h
>>
>
>


-- 
h

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[achuithb, 2017-01-10 14:53:21]

lgtm

[achuithb, 2017-01-10 14:53:28]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 14:53:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 15:52:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 15:52:07]

Dry run: This issue passed the CQ dry run.

[harpreet1, 2017-01-10 18:58:11]

The CQ bit was checked by harpreet@chromium.org

[commit-bot: I haz the power, 2017-01-10 18:58:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 19:04:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484074691674450, "parent_rev":
"3a461eebcb2c6fd9ae7fd066a1d9ad4f58fbfb59", "commit_rev":
"a6e8cd6a118d18cef16398294ca5b44e6f723dff"}

[commit-bot: I haz the power, 2017-01-10 19:05:13]

Description was changed from

==========
Whitelist extension used by autotest to use networkingPrivate.

BUG=672340
==========

to

==========
Whitelist extension used by autotest to use networkingPrivate.

BUG=672340

Review-Url: https://codereview.chromium.org/2614023003
Cr-Commit-Position: refs/heads/master@{#442645}
Committed:
https://chromium.googlesource.com/chromium/src/+/a6e8cd6a118d18cef16398294ca5...
==========

[commit-bot: I haz the power, 2017-01-10 19:05:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a6e8cd6a118d18cef16398294ca5...