Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Issue 2614023002: DevTools: Bump Gonzales-pe to 4.0.3 (Closed)

Created:
3 years, 11 months ago by paulirish
Modified:
3 years, 10 months ago
Reviewers:
lushnikov, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Bump Gonzales-pe to 4.0.3 BUG=678728 Review-Url: https://codereview.chromium.org/2614023002 Cr-Commit-Position: refs/heads/master@{#448737} Committed: https://chromium.googlesource.com/chromium/src/+/255e749e57448c43f5f9f49ba0bf842cd92a6b69

Patch Set 1 #

Patch Set 2 : css & scss syntaxes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8689 lines, -634 lines) Patch
M third_party/WebKit/Source/devtools/front_end/gonzales/gonzales-scss.js View 1 36 chunks +8689 lines, -634 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
paulirish
I checked out the latest release (4.0.3) and built with: yarn run build css scss ...
3 years, 11 months ago (2017-01-05 23:04:17 UTC) #2
pfeldman
lgtm
3 years, 11 months ago (2017-01-06 18:52:31 UTC) #4
lushnikov
Thanks Paul, lgtm
3 years, 11 months ago (2017-01-11 16:14:30 UTC) #5
lushnikov
shall we land this?
3 years, 11 months ago (2017-01-23 03:41:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614023002/20001
3 years, 10 months ago (2017-02-07 20:19:17 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 22:15:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/255e749e57448c43f5f9f49ba0bf...

Powered by Google App Engine
This is Rietveld 408576698