SharedWorker: Document lifetime of SharedWorkerHost

SharedWorker: Document lifetime of SharedWorkerHost

This is a followup CL for [1] and does following things:

- documents lifetime of SharedWorkerHost.
- removes SharedWorkerHost::WorkerContextDestroyed that clears member fields.
  This is not meaningful because the host is destructed immediately after this
  function.
- removes |instance_| checks because it's always valid.

[1] https://codereview.chromium.org/2601893002/#msg39

BUG=612308
Review-Url: https://codereview.chromium.org/2614013004
Cr-Commit-Position: refs/heads/master@{#441895}
Committed: https://chromium.googlesource.com/chromium/src/+/3898922f0e5f70f0cbd8a7edbc6d7001b0d60ec5

[nhiroki, 2017-01-06 02:29:23]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 02:29:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-01-06 03:04:29]

Patchset #1 (id:1) has been deleted

[nhiroki, 2017-01-06 03:07:36]

Description was changed from

==========
SharedWorker: Document lifetime of SharedWorkerHost

This is a followup CL for [1].

[1] https://codereview.chromium.org/2601893002/#msg39

BUG=
==========

to

==========
SharedWorker: Document lifetime of SharedWorkerHost

This CL is a followup CL for [1] and does following things:

- documents lifetime of SharedWorkerHost.
- removes SharedWorkerHost::WorkerContextDestroyed that clears member fields.
  This is not meaningful because the host is destructed immediately after this
  function.
- removes |instance_| checks because it's always valid.

[1] https://codereview.chromium.org/2601893002/#msg39

BUG=612308
==========

[nhiroki, 2017-01-06 03:08:18]

Description was changed from

==========
SharedWorker: Document lifetime of SharedWorkerHost

This CL is a followup CL for [1] and does following things:

- documents lifetime of SharedWorkerHost.
- removes SharedWorkerHost::WorkerContextDestroyed that clears member fields.
  This is not meaningful because the host is destructed immediately after this
  function.
- removes |instance_| checks because it's always valid.

[1] https://codereview.chromium.org/2601893002/#msg39

BUG=612308
==========

to

==========
SharedWorker: Document lifetime of SharedWorkerHost

This is a followup CL for [1] and does following things:

- documents lifetime of SharedWorkerHost.
- removes SharedWorkerHost::WorkerContextDestroyed that clears member fields.
  This is not meaningful because the host is destructed immediately after this
  function.
- removes |instance_| checks because it's always valid.

[1] https://codereview.chromium.org/2601893002/#msg39

BUG=612308
==========

[nhiroki, 2017-01-06 03:09:12]

nhiroki@chromium.org changed reviewers:
+ horo@chromium.org, kinuko@chromium.org

[nhiroki, 2017-01-06 03:09:13]

PTAL

[commit-bot: I haz the power, 2017-01-06 03:18:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 03:18:03]

Dry run: This issue passed the CQ dry run.

[horo, 2017-01-06 04:50:05]

lgtm with a nit

https://codereview.chromium.org/2614013004/diff/20001/content/browser/shared_...
File content/browser/shared_worker/shared_worker_host.h (right):

https://codereview.chromium.org/2614013004/diff/20001/content/browser/shared_...
content/browser/shared_worker/shared_worker_host.h:42: bool Send(IPC::Message*
message);
nit:
move to private.

[nhiroki, 2017-01-06 05:33:15]

Thank you.

https://codereview.chromium.org/2614013004/diff/20001/content/browser/shared_...
File content/browser/shared_worker/shared_worker_host.h (right):

https://codereview.chromium.org/2614013004/diff/20001/content/browser/shared_...
content/browser/shared_worker/shared_worker_host.h:42: bool Send(IPC::Message*
message);
On 2017/01/06 04:50:05, horo wrote:
> nit:
> move to private.

Done.

[nhiroki, 2017-01-06 05:33:25]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 05:33:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 06:21:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 06:21:11]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2017-01-06 07:03:04]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2017-01-06 07:03:04]

The patchset sent to the CQ was uploaded after l-g-t-m from horo@chromium.org
Link to the patchset: https://codereview.chromium.org/2614013004/#ps40001
(title: "move Send() to 'private' section")

[commit-bot: I haz the power, 2017-01-06 07:03:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 07:06:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483686184674660,
"parent_rev": "950a485a2b8a36beefe4bb7140274399390745c3", "commit_rev":
"3898922f0e5f70f0cbd8a7edbc6d7001b0d60ec5"}

[commit-bot: I haz the power, 2017-01-06 07:07:03]

Description was changed from

==========
SharedWorker: Document lifetime of SharedWorkerHost

This is a followup CL for [1] and does following things:

- documents lifetime of SharedWorkerHost.
- removes SharedWorkerHost::WorkerContextDestroyed that clears member fields.
  This is not meaningful because the host is destructed immediately after this
  function.
- removes |instance_| checks because it's always valid.

[1] https://codereview.chromium.org/2601893002/#msg39

BUG=612308
==========

to

==========
SharedWorker: Document lifetime of SharedWorkerHost

This is a followup CL for [1] and does following things:

- documents lifetime of SharedWorkerHost.
- removes SharedWorkerHost::WorkerContextDestroyed that clears member fields.
  This is not meaningful because the host is destructed immediately after this
  function.
- removes |instance_| checks because it's always valid.

[1] https://codereview.chromium.org/2601893002/#msg39

BUG=612308

Review-Url: https://codereview.chromium.org/2614013004
Cr-Commit-Position: refs/heads/master@{#441895}
Committed:
https://chromium.googlesource.com/chromium/src/+/3898922f0e5f70f0cbd8a7edbc6d...
==========

[commit-bot: I haz the power, 2017-01-06 07:07:04]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3898922f0e5f70f0cbd8a7edbc6d...