Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2613993002: Revert "Fix the Crash in the launcher's start page on Chrome OS." (Closed)

Created:
3 years, 11 months ago by xdai1
Modified:
3 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Fix the Crash in the launcher's start page on Chrome OS." This reverts commit 49ff293042830e095777651dc4058772af41fdda. This CL (https://codereview.chromium.org/2605463003/) has been merged to M56, so revert it on Tot. A better fix will be landed later. BUG=675150 TBR=xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2613993002 Cr-Commit-Position: refs/heads/master@{#441715} Committed: https://chromium.googlesource.com/chromium/src/+/826b507a7c29ed99f7389256ec19bfc5354acb77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M ui/app_list/views/search_result_container_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/start_page_view.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613993002/1
3 years, 11 months ago (2017-01-05 18:19:02 UTC) #2
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 18:51:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/826b507a7c29ed99f7389256ec19...

Powered by Google App Engine
This is Rietveld 408576698