Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2613963002: Remove WindowDelegate::OnRequestClose(). (Closed)

Created:
3 years, 11 months ago by riajiang
Modified:
3 years, 11 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WindowDelegate::OnRequestClose(). After fixing WindowTreeClient::RequestClose(window_id) (https://codereview.chromium.org/2604453002/), there's no more place that calls WindowDelegate::OnRequestClose(). BUG=none Review-Url: https://codereview.chromium.org/2613963002 Cr-Commit-Position: refs/heads/master@{#441720} Committed: https://chromium.googlesource.com/chromium/src/+/3f44dbb750d1f7ef1a77fb75f9710eca3225265f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M ui/aura/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/window_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
D ui/aura/window_delegate.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
riajiang
Hi sadrul@, PTAL, thanks!
3 years, 11 months ago (2017-01-05 16:29:48 UTC) #2
sadrul
lgtm
3 years, 11 months ago (2017-01-05 16:31:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613963002/1
3 years, 11 months ago (2017-01-05 18:57:38 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 19:03:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3f44dbb750d1f7ef1a77fb75f971...

Powered by Google App Engine
This is Rietveld 408576698