[MD Bookmarks] Test Util

[MD Bookmarks] Test Util

This CL contains a tree generate API to generate proper test elements.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2613943003
Cr-Commit-Position: refs/heads/master@{#442188}
Committed: https://chromium.googlesource.com/chromium/src/+/f2d674f16cbdc513213d62f85c5941789007fc4e

[jiaxi, 2017-01-06 03:07:48]

Description was changed from

==========
first commit for test-util

BUG=651980
==========

to

==========
first commit for test-util

BUG=651980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jiaxi, 2017-01-06 03:49:33]

Patchset #1 (id:1) has been deleted

[jiaxi, 2017-01-06 03:52:09]

Description was changed from

==========
first commit for test-util

BUG=651980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Test Util

This CL contains a tree generate API to generate proper test elements.

BUG=651980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jiaxi, 2017-01-06 03:52:29]

Description was changed from

==========
[MD Bookmarks] Test Util

This CL contains a tree generate API to generate proper test elements.

BUG=651980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Test Util

This CL contains a tree generate API to generate proper test elements.

BUG=651980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jiaxi, 2017-01-06 03:52:59]

jiaxi@google.com changed reviewers:
+ angelayang@google.com, calamity@chromium.org, tsergeant@chromium.org

[jiaxi, 2017-01-06 03:53:00]

https://codereview.chromium.org/2613943003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/sidebar_test.js (left):

https://codereview.chromium.org/2613943003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/sidebar_test.js:29: ];
The tree here is not a correct tree since the root node needs to have an id.
I've changed the tree a bit.

Also I used clang format to format the code here, let me know if I need to
change it to auto-indentation.

[calamity, 2017-01-06 04:44:37]

Looks good!

https://codereview.chromium.org/2613943003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/sidebar_test.js (left):

https://codereview.chromium.org/2613943003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/sidebar_test.js:29: ];
On 2017/01/06 03:53:00, jiaxi wrote:
> The tree here is not a correct tree since the root node needs to have an id.
> I've changed the tree a bit.
> 
> Also I used clang format to format the code here, let me know if I need to
> change it to auto-indentation.

clang-format forever and ever.

https://codereview.chromium.org/2613943003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/test_util.js (right):

https://codereview.chromium.org/2613943003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:15: * Generateis the following
properties for a tree for UI testing:
nit: Generates

https://codereview.chromium.org/2613943003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:16: * - Store the path to a
node inside the node.
Stores the path to the node inside each node.

https://codereview.chromium.org/2613943003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:20: function
setUpTreeForUITests(rootNode){
setupTreeForUITests.

https://codereview.chromium.org/2613943003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:22: rootNode.path = 'rootNode';
Newline after here.

https://codereview.chromium.org/2613943003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:40: newFolder.id = id;
Delete.

[jiaxi, 2017-01-06 04:49:45]

Patchset #2 (id:40001) has been deleted

[jiaxi, 2017-01-06 04:50:27]

https://codereview.chromium.org/2613943003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/test_util.js (right):

https://codereview.chromium.org/2613943003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:15: * Generateis the following
properties for a tree for UI testing:
On 2017/01/06 04:44:37, calamity wrote:
> nit: Generates

Done.

https://codereview.chromium.org/2613943003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:16: * - Store the path to a
node inside the node.
On 2017/01/06 04:44:37, calamity wrote:
> Stores the path to the node inside each node.

Done.

https://codereview.chromium.org/2613943003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:20: function
setUpTreeForUITests(rootNode){
On 2017/01/06 04:44:37, calamity wrote:
> setupTreeForUITests.

Done.

https://codereview.chromium.org/2613943003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:22: rootNode.path = 'rootNode';
On 2017/01/06 04:44:37, calamity wrote:
> Newline after here.

Done.

https://codereview.chromium.org/2613943003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:40: newFolder.id = id;
On 2017/01/06 04:44:37, calamity wrote:
> Delete.

Done.

[calamity, 2017-01-06 05:14:16]

lgtm

[tsergeant, 2017-01-08 23:39:29]

Cool!

https://codereview.chromium.org/2613943003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/store.js (right):

https://codereview.chromium.org/2613943003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/store.js:160: * @private
These aren't private anymore.

https://codereview.chromium.org/2613943003/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/test_util.js (right):

https://codereview.chromium.org/2613943003/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:15: * Generates the following
properties for a tree for UI testing:
This is the sort of comment that's likely to get out of date, because you're
describing what happens inside other functions. If you need to change initNodes
in the future, you probably won't remember to come back here and update this
comment.

My suggestion would be:

Initialize a tree for UI testing. This performs the same initialization as
`setupStore_` in <bookmarks-store>, but without the need for a store element in
the test.

[jiaxi, 2017-01-09 00:04:12]

https://codereview.chromium.org/2613943003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/store.js (right):

https://codereview.chromium.org/2613943003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/store.js:160: * @private
On 2017/01/08 23:39:29, tsergeant wrote:
> These aren't private anymore.

Done.

https://codereview.chromium.org/2613943003/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/test_util.js (right):

https://codereview.chromium.org/2613943003/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:15: * Generates the following
properties for a tree for UI testing:
On 2017/01/08 23:39:29, tsergeant wrote:
> This is the sort of comment that's likely to get out of date, because you're
> describing what happens inside other functions. If you need to change
initNodes
> in the future, you probably won't remember to come back here and update this
> comment.
> 
> My suggestion would be:
> 
> Initialize a tree for UI testing. This performs the same initialization as
> `setupStore_` in <bookmarks-store>, but without the need for a store element
in
> the test.

Done.

[tsergeant, 2017-01-09 00:09:03]

lgtm

[jiaxi, 2017-01-09 00:09:50]

The CQ bit was checked by jiaxi@google.com

[jiaxi, 2017-01-09 00:09:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2613943003/#ps80001
(title: "remove closure and comment update")

[commit-bot: I haz the power, 2017-01-09 00:09:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 00:58:27]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483920590640420,
"parent_rev": "78c8556e215fe9def6cc73e31d36c8e43a4a157e", "commit_rev":
"f2d674f16cbdc513213d62f85c5941789007fc4e"}

[commit-bot: I haz the power, 2017-01-09 00:58:55]

Description was changed from

==========
[MD Bookmarks] Test Util

This CL contains a tree generate API to generate proper test elements.

BUG=651980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Test Util

This CL contains a tree generate API to generate proper test elements.

BUG=651980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2613943003
Cr-Commit-Position: refs/heads/master@{#442188}
Committed:
https://chromium.googlesource.com/chromium/src/+/f2d674f16cbdc513213d62f85c59...
==========

[commit-bot: I haz the power, 2017-01-09 00:58:57]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f2d674f16cbdc513213d62f85c59...

[jiaxi, 2017-01-10 23:03:30]

Description was changed from

==========
[MD Bookmarks] Test Util

This CL contains a tree generate API to generate proper test elements.

BUG=651980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2613943003
Cr-Commit-Position: refs/heads/master@{#442188}
Committed:
https://chromium.googlesource.com/chromium/src/+/f2d674f16cbdc513213d62f85c59...
==========

to

==========
[MD Bookmarks] Test Util

This CL contains a tree generate API to generate proper test elements.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2613943003
Cr-Commit-Position: refs/heads/master@{#442188}
Committed:
https://chromium.googlesource.com/chromium/src/+/f2d674f16cbdc513213d62f85c59...
==========