Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2613863007: Track context menu creation for suggestions. (Closed)

Created:
3 years, 11 months ago by Bernhard Bauer
Modified:
3 years, 11 months ago
Reviewers:
dgn
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Track context menu creation for suggestions. Before this, the method existed on NewTabPageManager, but was never actually called. BUG=yeah Review-Url: https://codereview.chromium.org/2613863007 Cr-Commit-Position: refs/heads/master@{#442849} Committed: https://chromium.googlesource.com/chromium/src/+/8ef5dcc3ad1454c9eba222c373e2ad5db608fa73

Patch Set 1 #

Patch Set 2 : format #

Messages

Total messages: 13 (8 generated)
Bernhard Bauer
Oops :)
3 years, 11 months ago (2017-01-06 15:37:46 UTC) #4
dgn
lgtm
3 years, 11 months ago (2017-01-06 17:14:38 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2593523005 Patch 140001). Please resolve the dependency and ...
3 years, 11 months ago (2017-01-06 17:17:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613863007/20001
3 years, 11 months ago (2017-01-11 09:20:18 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 10:22:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8ef5dcc3ad1454c9eba222c373e2...

Powered by Google App Engine
This is Rietveld 408576698