Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java

Issue 2613863006: Add a ThreadLocal flag to replace the reflection in shouldTriggerDelayedOnCreateInputConnection() (Closed)
Patch Set: fix cast error Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java
diff --git a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java
index 68452ed5d89f3bc263c53c0b43876a28a40f1718..4cdf33b24461c092591ee89ddb8b6b686cd24d03 100644
--- a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java
+++ b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java
@@ -13,7 +13,6 @@ import android.view.inputmethod.EditorInfo;
import android.view.inputmethod.InputConnection;
import org.chromium.base.Log;
-import org.chromium.base.annotations.UsedByReflection;
import org.chromium.content.browser.ContentViewCore;
import org.chromium.content.browser.input.InputMethodManagerWrapper;
import org.chromium.content.browser.input.Range;
@@ -24,7 +23,6 @@ import java.util.List;
/**
* Overrides InputMethodManagerWrapper for testing purposes.
*/
-@UsedByReflection("ThreadedInputConnectionFactory.java")
public class TestInputMethodManagerWrapper extends InputMethodManagerWrapper {
private static final String TAG = "cr_Ime";
@@ -52,6 +50,7 @@ public class TestInputMethodManagerWrapper extends InputMethodManagerWrapper {
mRestartInputCounter++;
Log.d(TAG, "restartInput: count [%d]", mRestartInputCounter);
EditorInfo editorInfo = new EditorInfo();
+ mContentViewCore.setTriggerDelayedOnCreateInputConnection(false);
mInputConnection = mContentViewCore.onCreateInputConnection(editorInfo);
}
@@ -62,6 +61,7 @@ public class TestInputMethodManagerWrapper extends InputMethodManagerWrapper {
Log.d(TAG, "showSoftInput: count [%d]", mShowSoftInputCounter);
if (mInputConnection != null) return;
EditorInfo editorInfo = new EditorInfo();
+ mContentViewCore.setTriggerDelayedOnCreateInputConnection(false);
mInputConnection = mContentViewCore.onCreateInputConnection(editorInfo);
}

Powered by Google App Engine
This is Rietveld 408576698