Add a ThreadLocal flag to replace the reflection in shouldTriggerDelayedOnCreateInputConnection()

content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionProxyView.java

Index: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionProxyView.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionProxyView.java b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionProxyView.java
index 31c59f69c44376f9f87bb9a1429d46d899d7b78a..b32b10cea9f12dc60d2198cd92eeb5ca09364007 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionProxyView.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionProxyView.java
@@ -13,7 +13,7 @@ import android.view.inputmethod.InputConnection;
 
 import org.chromium.base.Log;
 import org.chromium.base.ThreadUtils;
-import org.chromium.base.annotations.UsedByReflection;
+import org.chromium.content.browser.ContentView;
 
 import java.util.concurrent.Callable;
 import java.util.concurrent.atomic.AtomicBoolean;
@@ -22,7 +22,6 @@ import java.util.concurrent.atomic.AtomicReference;
 /**
  * This is a fake View that is only exposed to InputMethodManager.
  */
-@UsedByReflection("ThreadedInputConnectionFactory.java")
 public class ThreadedInputConnectionProxyView extends View {
     private static final String TAG = "cr_Ime";
     private static final boolean DEBUG_LOGS = false;
@@ -93,6 +92,9 @@ public class ThreadedInputConnectionProxyView extends View {
         return ThreadUtils.runOnUiThreadBlockingNoException(new Callable<InputConnection>() {
             @Override
             public InputConnection call() throws Exception {
+                if (mContainerView instanceof ContentView) {
+                    ((ContentView) mContainerView).setTriggerDelayedOnCreateInputConnection(false);
+                }

[yabinh, 2017/01/09 07:33:11]

We can't import 'org.chromium.android_webview.test.AwTestContainerView' into
ThreadedInputConnectionProxyView.java, so we can't do the similar trick here:

'''
                if (mContainerView instanceof AwTestContainerView) {
                    ((AwTestContainerView) mContainerView)
                            .setTriggerDelayedOnCreateInputConnection(false);
                }
'''


Here is part of the call stack for WebKitHitTestTest.testEditTextType:

'''
01-09 15:17:41.580 16855 16855 E cr_hyb  :
org.chromium.content.browser.input.ThreadedInputConnectionFactory.initializeAndGet(ThreadedInputConnectionFactory.java:147)
01-09 15:17:41.580 16855 16855 E cr_hyb  :
org.chromium.content.browser.input.ThreadedInputConnectionFactory.initializeAndGet(ThreadedInputConnectionFactory.java:22)
01-09 15:17:41.580 16855 16855 E cr_hyb  :
org.chromium.content.browser.input.ImeAdapter.onCreateInputConnection(ImeAdapter.java:199)
01-09 15:17:41.580 16855 16855 E cr_hyb  :
org.chromium.content.browser.ContentViewCore.onCreateInputConnection(ContentViewCore.java:1398)
01-09 15:17:41.580 16855 16855 E cr_hyb  :
org.chromium.android_webview.AwContents$AwViewMethodsImpl.onCreateInputConnection(AwContents.java:3056)
01-09 15:17:41.580 16855 16855 E cr_hyb  :
org.chromium.android_webview.AwContents.onCreateInputConnection(AwContents.java:1929)
01-09 15:17:41.580 16855 16855 E cr_hyb  :
org.chromium.android_webview.test.AwTestContainerView.onCreateInputConnection(AwTestContainerView.java:355)
01-09 15:17:41.580 16855 16855 E cr_hyb  :
org.chromium.content.browser.input.ThreadedInputConnectionProxyView$1.call(ThreadedInputConnectionProxyView.java:98)
01-09 15:17:41.580 16855 16855 E cr_hyb  :
org.chromium.content.browser.input.ThreadedInputConnectionProxyView$1.call(ThreadedInputConnectionProxyView.java:92)
01-09 15:17:41.580 16855 16855 E cr_hyb  :
java.util.concurrent.FutureTask.run(FutureTask.java:237)
01-09 15:17:41.580 16855 16855 E cr_hyb  :
android.os.Handler.handleCallback(Handler.java:739)
01-09 15:17:41.580 16855 16855 E cr_hyb  :
android.os.Handler.dispatchMessage(Handler.java:95)
01-09 15:17:41.580 16855 16855 E cr_hyb  :
android.os.Looper.loop(Looper.java:148)
01-09 15:17:41.580 16855 16855 E cr_hyb  :
android.app.ActivityThread.main(ActivityThread.java:5417)
01-09 15:17:41.581 16855 16855 E cr_hyb  :
java.lang.reflect.Method.invoke(Native Method)
'''

[Changwan Ryu, 2017/01/10 06:28:25]

Since ProxyView is owned by Factory, could you just pass Factory as a parameter
to a constructor instead? Then you don't need a lot of plumbing. Then you can do
the following:

mFactory.setCalledByProxyView(true);
InputConnection connection = mContainerView.onCreateInputConnection(outAttrs);
mFactory.setCalledByProxyView(false);
return connection;

                 return mContainerView.onCreateInputConnection(outAttrs);
             }
         });