Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 2613863006: Add a ThreadLocal flag to replace the reflection in shouldTriggerDelayedOnCreateInputConnection() (Closed)
Patch Set: fix cast error Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
index 561a2d967cce810899fa1b1e553fb6777ec9f9e2..8f4baa4cc1efd51218ff9e693c3cdf6a1ae71f47 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
@@ -22,6 +22,7 @@ import android.view.inputmethod.EditorInfo;
import android.view.inputmethod.InputConnection;
import org.chromium.base.ThreadUtils;
+import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.UrlUtils;
import org.chromium.content.browser.ContentViewCore;
@@ -1763,12 +1764,28 @@ public class ImeTest extends ContentShellTestBase {
mFactory = factory;
}
+ private static ThreadLocal<Boolean> sTriggerDelayedOnCreateInputConnection =
+ new ThreadLocal<Boolean>() {
+ @SuppressFBWarnings("CHROMIUM_SYNCHRONIZED_METHOD")
+ @Override
+ protected synchronized Boolean initialValue() {
+ return true;
+ }
+ };
+
+ @Override
+ public void setTriggerDelayedOnCreateInputConnection(final boolean trigger) {
+ sTriggerDelayedOnCreateInputConnection.set(trigger);
+ }
+
@Override
public ChromiumBaseInputConnection initializeAndGet(View view, ImeAdapter imeAdapter,
int inputType, int inputFlags, int inputMode, int selectionStart, int selectionEnd,
EditorInfo outAttrs) {
mTextInputTypeList.add(inputType);
mOutAttrs = outAttrs;
+ mFactory.setTriggerDelayedOnCreateInputConnection(
+ sTriggerDelayedOnCreateInputConnection.get());
return mFactory.initializeAndGet(view, imeAdapter, inputType, inputMode, inputFlags,
selectionStart, selectionEnd, outAttrs);
}

Powered by Google App Engine
This is Rietveld 408576698