Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2613863004: [layoutng] For consistency, always use Style() to access the style (Closed)

Created:
3 years, 11 months ago by cbiesinger
Modified:
3 years, 11 months ago
Reviewers:
atotic, eae
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] For consistency, always use Style() to access the style R=atotic@chromium.org,eae@chromium.org Review-Url: https://codereview.chromium.org/2613863004 Cr-Commit-Position: refs/heads/master@{#441789} Committed: https://chromium.googlesource.com/chromium/src/+/9d13a9813130450975149a1a05a1e4094ed407a0

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
cbiesinger
3 years, 11 months ago (2017-01-05 20:59:43 UTC) #1
cbiesinger
fix typo
3 years, 11 months ago (2017-01-05 21:13:51 UTC) #6
atotic
On 2017/01/05 at 21:13:51, cbiesinger wrote: > fix typo lgtm
3 years, 11 months ago (2017-01-05 21:17:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613863004/20001
3 years, 11 months ago (2017-01-05 21:18:55 UTC) #12
eae
LGTM
3 years, 11 months ago (2017-01-05 22:59:12 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 01:28:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9d13a9813130450975149a1a05a1...

Powered by Google App Engine
This is Rietveld 408576698