Implements CSSPropertyAPI for the offset-position property.

Implements CSSPropertyAPI for the offset-position property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyOffsetPosition from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIOffsetPosition.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIOffsetPosition.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIOffsetPosition.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
Review-Url: https://codereview.chromium.org/2613863002
Cr-Commit-Position: refs/heads/master@{#442860}
Committed: https://chromium.googlesource.com/chromium/src/+/aa222b4550e646da3c723394d0835e00be7d8ba1

[aazzam, 2017-01-05 04:01:48]

aazzam@google.com changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-01-05 04:22:55]

lgtm

[aazzam, 2017-01-05 04:24:17]

Description was changed from

==========
Implemented CSSPropertyAPI for offset-position property.

Added CSSPropertyAPIOffsetPosition which implements CSSPropertyAPI for
the offset-position property. Moved parsing logic from CSSPropertyParser
to the .cpp file. Added flag to CSSProperties.in so that the .h file
will be generated.

BUG=668012
==========

to

==========
Implemented CSSPropertyAPI for offset-position property.

Added CSSPropertyAPIOffsetPosition which implements CSSPropertyAPI for
the offset-position property. Parsing logic is the same as before, 
just was moved from CSSPropertyParser to the .cpp file. Added flag 
to CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

[aazzam, 2017-01-08 02:45:23]

Description was changed from

==========
Implemented CSSPropertyAPI for offset-position property.

Added CSSPropertyAPIOffsetPosition which implements CSSPropertyAPI for
the offset-position property. Parsing logic is the same as before, 
just was moved from CSSPropertyParser to the .cpp file. Added flag 
to CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the offset-position property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyOffsetPosition from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIOffsetPosition.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIOffsetPosition.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIOffsetPosition.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
==========

[aazzam, 2017-01-08 02:45:31]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[sashab, 2017-01-09 05:19:35]

lgtm

https://codereview.chromium.org/2613863002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp
(right):

https://codereview.chromium.org/2613863002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp:7:
#include "core/css/CSSValuePair.h"
Is this needed?

https://codereview.chromium.org/2613863002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp:7:
#include "core/css/CSSValuePair.h"
Is this needed?

[aazzam, 2017-01-10 00:13:03]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 00:14:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 00:20:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 00:20:02]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aazzam, 2017-01-10 06:22:15]

https://codereview.chromium.org/2613863002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp
(right):

https://codereview.chromium.org/2613863002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp:7:
#include "core/css/CSSValuePair.h"
On 2017/01/09 at 05:19:35, sashab wrote:
> Is this needed?

yeah it's needed to assign a CSSValueList* from consumePosition to a CSSValue*
:)

[aazzam, 2017-01-10 06:22:54]

On 2017/01/10 at 06:22:15, aazzam wrote:
>
https://codereview.chromium.org/2613863002/diff/40001/third_party/WebKit/Sour...
> File
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp
(right):
> 
>
https://codereview.chromium.org/2613863002/diff/40001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp:7:
#include "core/css/CSSValuePair.h"
> On 2017/01/09 at 05:19:35, sashab wrote:
> > Is this needed?
> 
> yeah it's needed to assign a CSSValueList* from consumePosition to a CSSValue*
:)

my bad, I mean CSSValuePair*

[aazzam, 2017-01-10 06:26:57]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 06:27:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 06:47:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 06:47:53]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[sashab, 2017-01-10 23:13:04]

still LGTM :)

[aazzam, 2017-01-11 01:59:43]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:00:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 02:13:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 02:13:18]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[aazzam, 2017-01-11 02:30:40]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:31:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 02:48:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 02:48:37]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[aazzam, 2017-01-11 06:28:24]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 06:28:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 07:50:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 07:50:18]

Dry run: This issue passed the CQ dry run.

[aazzam, 2017-01-11 10:27:31]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-01-11 10:27:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org, sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2613863002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-11 10:27:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 10:35:08]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484130451088650,
"parent_rev": "ae00364f8accb45d8ee99270c9bfff763731c3f3", "commit_rev":
"aa222b4550e646da3c723394d0835e00be7d8ba1"}

[commit-bot: I haz the power, 2017-01-11 10:35:38]

Description was changed from

==========
Implements CSSPropertyAPI for the offset-position property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyOffsetPosition from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIOffsetPosition.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIOffsetPosition.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIOffsetPosition.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the offset-position property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyOffsetPosition from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIOffsetPosition.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIOffsetPosition.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIOffsetPosition.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2613863002
Cr-Commit-Position: refs/heads/master@{#442860}
Committed:
https://chromium.googlesource.com/chromium/src/+/aa222b4550e646da3c723394d083...
==========

[commit-bot: I haz the power, 2017-01-11 10:35:39]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/aa222b4550e646da3c723394d083...