LayoutTests/fast/multicol/border-padding-pagination.html - Issue 261383004: [New Multicolumn] Improve balancing for border/padding and empty block content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/multicol/border-padding-pagination.html

Issue 261383004: [New Multicolumn] Improve balancing for border/padding and empty block content. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: ... aaand, better expect the test to pass, now that it's actually fixed, hm? :-P Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/multicol/balance-unbreakable.html ('K') | « LayoutTests/fast/multicol/balance-unbreakable-expected.txt ('k') | Source/core/rendering/RenderBlockFlow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/multicol/border-padding-pagination.html

diff --git a/LayoutTests/fast/multicol/border-padding-pagination.html b/LayoutTests/fast/multicol/border-padding-pagination.html

index 55ea64ba0aa679474221ac7c0a56eaab20356fc1..54992693740664ca2475e3bbdaf90fef6f7f29ee 100644

--- a/LayoutTests/fast/multicol/border-padding-pagination.html

+++ b/LayoutTests/fast/multicol/border-padding-pagination.html

@@ -1,3 +1,12 @@

+<!-- For the new ("region-based") multicol implementation, this test is superseded by the following

+ tests:

+ balance-short-trailing-empty-block.html

+ balance-trailing-border.html

+ balance-unbreakable.html

+ Rather than rebaselining the results, this test should be deleted when enabling the new

+ implementation. -->

Julien - ping for review 2014/05/09 18:23:53 I like such comments to be dumped in the output so

mstensho (USE GERRIT) 2014/05/10 16:28:22 There shouldn't be any need to do this. Once we en

<html>

Julien - ping for review 2014/05/09 18:23:53 On top of that, this test doesn't have a doctype :

mstensho (USE GERRIT) 2014/05/10 16:28:22 Yeah, there's absolutely no reason to run this one

<body>