LayoutTests/fast/multicol/border-padding-pagination.html - Issue 261383004: [New Multicolumn] Improve balancing for border/padding and empty block content.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/border-padding-pagination.html

Issue 261383004: [New Multicolumn] Improve balancing for border/padding and empty block content. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: ... aaand, better expect the test to pass, now that it's actually fixed, hm? :-P Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/multicol/balance-unbreakable.html ('K') | « LayoutTests/fast/multicol/balance-unbreakable-expected.txt ('k') | Source/core/rendering/RenderBlockFlow.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	1 <!-- For the new ("region-based") multicol implementation, this test is supersed ed by the following

	2 tests:

	3

	4 balance-short-trailing-empty-block.html

	5 balance-trailing-border.html

	6 balance-unbreakable.html

	7

	8 Rather than rebaselining the results, this test should be deleted when enab ling the new

	9 implementation. -->
	Julien - ping for review 2014/05/09 18:23:53 I like such comments to be dumped in the output so I like such comments to be dumped in the output so that people will see it. Also let's link to the new multi-column master bug to make this actionable. mstensho (USE GERRIT) 2014/05/10 16:28:22 There shouldn't be any need to do this. Once we en Show quoted text On 2014/05/09 18:23:53, Julien Chaffraix - PST wrote: > I like such comments to be dumped in the output so that people will see it. > > Also let's link to the new multi-column master bug to make this actionable. There shouldn't be any need to do this. Once we enable the new implementation, we're going to notice that this test fails, read the comment and just remove the test. This DRT + pixel test is superseded by three javascript tests.
1 <html>	10 <html>
	Julien - ping for review 2014/05/09 18:23:53 On top of that, this test doesn't have a doctype : On top of that, this test doesn't have a doctype :( mstensho (USE GERRIT) 2014/05/10 16:28:22 Yeah, there's absolutely no reason to run this one Show quoted text On 2014/05/09 18:23:53, Julien Chaffraix - PST wrote: > On top of that, this test doesn't have a doctype :( Yeah, there's absolutely no reason to run this one in quirks mode. But the test is going away, and enabling strict mode results in a different render tree (the RenderLayer for the HTML element takes up the entire viewport in quirks mode?). So I prefer to keep it as it is rather than rebaselining.
2 <body>	11 <body>

3 <div style="-webkit-column-count:2;-moz-column-count:2; border:2px solid maroon" >	12 <div style="-webkit-column-count:2;-moz-column-count:2; border:2px solid maroon" >

4 <div style="height:110px"></div>	13 <div style="height:110px"></div>

5 <div style="background-color:lime; border:2px solid black; width:375px; ">	14 <div style="background-color:lime; border:2px solid black; width:375px; ">

6 <div style="margin: 0 10px; background-color:green; border: 2px solid blue">	15 <div style="margin: 0 10px; background-color:green; border: 2px solid blue">

7 <span style="font-size:64px">In 2nd column</span>	16 <span style="font-size:64px">In 2nd column</span>

8 </div>	17 </div>

9 </div>	18 </div>

OLD	NEW