LayoutTests/fast/multicol/balance-unbreakable.html - Issue 261383004: [New Multicolumn] Improve balancing for border/padding and empty block content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/multicol/balance-unbreakable.html

Issue 261383004: [New Multicolumn] Improve balancing for border/padding and empty block content. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: ... aaand, better expect the test to pass, now that it's actually fixed, hm? :-P Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/multicol/balance-short-trailing-empty-block.html ('K') | « LayoutTests/fast/multicol/balance-trailing-border2-expected.txt ('k') | LayoutTests/fast/multicol/balance-unbreakable-expected.txt » ('j') | LayoutTests/fast/multicol/border-padding-pagination.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/multicol/balance-unbreakable.html

diff --git a/LayoutTests/fast/multicol/balance-unbreakable.html b/LayoutTests/fast/multicol/balance-unbreakable.html

new file mode 100644

index 0000000000000000000000000000000000000000..747c4e8c5ebbf47621a88153e4ecacf311a7fc3d

--- /dev/null

+++ b/LayoutTests/fast/multicol/balance-unbreakable.html

@@ -0,0 +1,24 @@

+<!DOCTYPE html>

+<script src="../../resources/js-test.js"></script>

+<script>

+ description("Tests that an image at a column boundary is recorded properly for balancing");

+ if (window.internals)

+ internals.settings.setRegionBasedColumnsEnabled(true);

+</script>

+<style>

+ #mc > * { visibility:hidden; }

Julien - ping for review 2014/05/09 18:23:53 Do we need the visibility hidden as this is a text

mstensho (USE GERRIT) 2014/05/10 16:28:22 Done.

+</style>

+<p>There should be a <em>square</em> below.</p>

+<div id="mc" style="-webkit-columns:3; columns:3; width:7em; float:left; orphans:1; widows:1; background:olive;">

+ <div style="line-height:4em;">line</div>

+ <div style="line-height:8em;">line</div>

+ <img alt="x" style="display:block; height:2em;">

+ <div style="line-height:4em;">line</div>

+ <div style="line-height:10em;">line</div>

+ <div style="line-height:2em;">line</div>

+ <div style="line-height:6em;">line</div>

+</div>

+<div style="float:left; width:7em; height:14em; background:olive;"></div>

+<script>

+ shouldBe("mc.offsetHeight", "224");

+</script>