LayoutTests/fast/multicol/balance-short-trailing-empty-block.html - Issue 261383004: [New Multicolumn] Improve balancing for border/padding and empty block content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/multicol/balance-short-trailing-empty-block.html

Issue 261383004: [New Multicolumn] Improve balancing for border/padding and empty block content. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: ... aaand, better expect the test to pass, now that it's actually fixed, hm? :-P Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/multicol/balance-short-trailing-empty-block-expected.txt » ('j') | LayoutTests/fast/multicol/balance-unbreakable.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/multicol/balance-short-trailing-empty-block.html

diff --git a/LayoutTests/fast/multicol/balance-short-trailing-empty-block.html b/LayoutTests/fast/multicol/balance-short-trailing-empty-block.html

new file mode 100644

index 0000000000000000000000000000000000000000..15d1956ee044a2c207c4dd0d4e3a5fdb26299971

--- /dev/null

+++ b/LayoutTests/fast/multicol/balance-short-trailing-empty-block.html

@@ -0,0 +1,16 @@

+<!DOCTYPE html>

+<script src="../../resources/js-test.js"></script>

+<script>

+ description("Tests that a block a column boundary is recorded properly for balancing");

+ if (window.internals)

+ internals.settings.setRegionBasedColumnsEnabled(true);

+</script>

+<p>Both words below should be in the the right column.</p>

Julien - ping for review 2014/05/09 18:23:53 Nit: Add a <div id="console"> after this so that t

mstensho (USE GERRIT) 2014/05/10 16:28:22 Done. Had to move description() down to make it wo

+<div id="mc" style="-webkit-columns:2; columns:2; orphans:1; widows:1; -webkit-column-rule:1px solid; column-rule:1px solid; background:olive;">

+ <div style="height:120px;"></div>

+ <div style="line-height:80px;">right<br>column</div>

+ <div style="height:30px;"></div>

+</div>

+<script>

+ shouldBe("mc.offsetHeight", "190");

+</script>