Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10036)

Unified Diff: chromecast/browser/cast_content_browser_client.h

Issue 2613803003: Simplifying ContentBrowserClient::GetAdditionalMappedFiles...() (Closed)
Patch Set: Addressed jam@'s comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chromecast/browser/cast_content_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/cast_content_browser_client.h
diff --git a/chromecast/browser/cast_content_browser_client.h b/chromecast/browser/cast_content_browser_client.h
index 38f97c8d4cad708d2ab4660b13f41e60827b05fd..5515558f55b810e3335e8fa77ec68c61043ab86c 100644
--- a/chromecast/browser/cast_content_browser_client.h
+++ b/chromecast/browser/cast_content_browser_client.h
@@ -91,6 +91,10 @@ class CastContentBrowserClient : public content::ContentBrowserClient {
media::MediaResourceTracker* media_resource_tracker();
media::MediaPipelineBackendManager* media_pipeline_backend_manager();
+
+ ::media::ScopedAudioManagerPtr CreateAudioManager(
+ ::media::AudioLogFactory* audio_log_factory) override;
+ std::unique_ptr<::media::CdmFactory> CreateCdmFactory() override;
#endif
media::MediaCapsImpl* media_caps();
@@ -153,21 +157,10 @@ class CastContentBrowserClient : public content::ContentBrowserClient {
void RegisterInProcessServices(StaticServiceMap* services) override;
std::unique_ptr<base::Value> GetServiceManifestOverlay(
base::StringPiece service_name) override;
-#if defined(OS_ANDROID)
- void GetAdditionalMappedFilesForChildProcess(
- const base::CommandLine& command_line,
- int child_process_id,
- content::FileDescriptorInfo* mappings,
- std::map<int, base::MemoryMappedFile::Region>* regions) override;
-#else
- ::media::ScopedAudioManagerPtr CreateAudioManager(
- ::media::AudioLogFactory* audio_log_factory) override;
- std::unique_ptr<::media::CdmFactory> CreateCdmFactory() override;
void GetAdditionalMappedFilesForChildProcess(
const base::CommandLine& command_line,
int child_process_id,
content::FileDescriptorInfo* mappings) override;
-#endif // defined(OS_ANDROID)
void GetAdditionalWebUISchemes(
std::vector<std::string>* additional_schemes) override;
content::DevToolsManagerDelegate* GetDevToolsManagerDelegate() override;
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chromecast/browser/cast_content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698