Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Side by Side Diff: chromecast/browser/cast_content_browser_client.h

Issue 2613803003: Simplifying ContentBrowserClient::GetAdditionalMappedFiles...() (Closed)
Patch Set: Addressed jam@'s comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMECAST_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_ 5 #ifndef CHROMECAST_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_
6 #define CHROMECAST_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_ 6 #define CHROMECAST_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 84
85 // Creates a MediaPipelineDevice (CMA backend) for media playback, called 85 // Creates a MediaPipelineDevice (CMA backend) for media playback, called
86 // once per media player instance. 86 // once per media player instance.
87 virtual std::unique_ptr<media::MediaPipelineBackend> 87 virtual std::unique_ptr<media::MediaPipelineBackend>
88 CreateMediaPipelineBackend(const media::MediaPipelineDeviceParams& params, 88 CreateMediaPipelineBackend(const media::MediaPipelineDeviceParams& params,
89 const std::string& audio_device_id); 89 const std::string& audio_device_id);
90 90
91 media::MediaResourceTracker* media_resource_tracker(); 91 media::MediaResourceTracker* media_resource_tracker();
92 92
93 media::MediaPipelineBackendManager* media_pipeline_backend_manager(); 93 media::MediaPipelineBackendManager* media_pipeline_backend_manager();
94
95 ::media::ScopedAudioManagerPtr CreateAudioManager(
96 ::media::AudioLogFactory* audio_log_factory) override;
97 std::unique_ptr<::media::CdmFactory> CreateCdmFactory() override;
94 #endif 98 #endif
95 media::MediaCapsImpl* media_caps(); 99 media::MediaCapsImpl* media_caps();
96 100
97 // Invoked when the metrics client ID changes. 101 // Invoked when the metrics client ID changes.
98 virtual void SetMetricsClientId(const std::string& client_id); 102 virtual void SetMetricsClientId(const std::string& client_id);
99 103
100 // Allows registration of extra metrics providers. 104 // Allows registration of extra metrics providers.
101 virtual void RegisterMetricsProviders( 105 virtual void RegisterMetricsProviders(
102 ::metrics::MetricsService* metrics_service); 106 ::metrics::MetricsService* metrics_service);
103 107
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 bool user_gesture, 150 bool user_gesture,
147 bool opener_suppressed, 151 bool opener_suppressed,
148 content::ResourceContext* context, 152 content::ResourceContext* context,
149 bool* no_javascript_access) override; 153 bool* no_javascript_access) override;
150 void ExposeInterfacesToRenderer( 154 void ExposeInterfacesToRenderer(
151 service_manager::InterfaceRegistry* registry, 155 service_manager::InterfaceRegistry* registry,
152 content::RenderProcessHost* render_process_host) override; 156 content::RenderProcessHost* render_process_host) override;
153 void RegisterInProcessServices(StaticServiceMap* services) override; 157 void RegisterInProcessServices(StaticServiceMap* services) override;
154 std::unique_ptr<base::Value> GetServiceManifestOverlay( 158 std::unique_ptr<base::Value> GetServiceManifestOverlay(
155 base::StringPiece service_name) override; 159 base::StringPiece service_name) override;
156 #if defined(OS_ANDROID)
157 void GetAdditionalMappedFilesForChildProcess(
158 const base::CommandLine& command_line,
159 int child_process_id,
160 content::FileDescriptorInfo* mappings,
161 std::map<int, base::MemoryMappedFile::Region>* regions) override;
162 #else
163 ::media::ScopedAudioManagerPtr CreateAudioManager(
164 ::media::AudioLogFactory* audio_log_factory) override;
165 std::unique_ptr<::media::CdmFactory> CreateCdmFactory() override;
166 void GetAdditionalMappedFilesForChildProcess( 160 void GetAdditionalMappedFilesForChildProcess(
167 const base::CommandLine& command_line, 161 const base::CommandLine& command_line,
168 int child_process_id, 162 int child_process_id,
169 content::FileDescriptorInfo* mappings) override; 163 content::FileDescriptorInfo* mappings) override;
170 #endif // defined(OS_ANDROID)
171 void GetAdditionalWebUISchemes( 164 void GetAdditionalWebUISchemes(
172 std::vector<std::string>* additional_schemes) override; 165 std::vector<std::string>* additional_schemes) override;
173 content::DevToolsManagerDelegate* GetDevToolsManagerDelegate() override; 166 content::DevToolsManagerDelegate* GetDevToolsManagerDelegate() override;
174 167
175 protected: 168 protected:
176 CastContentBrowserClient(); 169 CastContentBrowserClient();
177 170
178 URLRequestContextFactory* url_request_context_factory() const { 171 URLRequestContextFactory* url_request_context_factory() const {
179 return url_request_context_factory_.get(); 172 return url_request_context_factory_.get();
180 } 173 }
(...skipping 22 matching lines...) Expand all
203 CastBrowserMainParts* cast_browser_main_parts_; 196 CastBrowserMainParts* cast_browser_main_parts_;
204 std::unique_ptr<URLRequestContextFactory> url_request_context_factory_; 197 std::unique_ptr<URLRequestContextFactory> url_request_context_factory_;
205 198
206 DISALLOW_COPY_AND_ASSIGN(CastContentBrowserClient); 199 DISALLOW_COPY_AND_ASSIGN(CastContentBrowserClient);
207 }; 200 };
208 201
209 } // namespace shell 202 } // namespace shell
210 } // namespace chromecast 203 } // namespace chromecast
211 204
212 #endif // CHROMECAST_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_ 205 #endif // CHROMECAST_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_
OLDNEW
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chromecast/browser/cast_content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698