Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2613793007: Revert of [Mojo Video Capture] Simplify media::VideoCaptureDevice::Client:Buffer to a struct (Closed)

Created:
3 years, 11 months ago by chfremer
Modified:
3 years, 11 months ago
Reviewers:
mcasas, miu
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, darin (slow to review), miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mojo Video Capture] Simplify media::VideoCaptureDevice::Client:Buffer to a struct (patchset #8 id:220001 of https://codereview.chromium.org/2573223002/ ) Reason for revert: In order to revert https://codereview.chromium.org/2592303002/, need to revert this first, since it depends on it. Original issue's description: > [Mojo Video Capture] Simplify media::VideoCaptureDevice::Client:Buffer to a struct > > In interface media::VideoCaptureDevice::Client, change interface Buffer to a > move-only struct. The new struct separates the concerns of providing access > handles (for in-process as well as for inter-process transit) from access > permissions. This allows clients to explicitly obtain in-process memory-mapped > handles when they need it. Clients who only want to pass along the buffer or > move it across process boundaries do not need memory-mapped handles. > > In interface media::VideoCaptureBufferPool, renamed > GetBufferHandle() -> GetHandleForInProcessAccess() > GetHandleForTransit() -> GetHandleForInterProcessTransit(). > > Removed outdated implementation in video_capture Mojo service. We leave the > implementation empty, until refactoring the interfaces has been completed. > > This CL is part of the Mojo Video Capture work. For the bigger picture, > see [1] CL1.9.10 > > For a peek at the follow-up CLs, please see > https://codereview.chromium.org/2607203002/ > https://codereview.chromium.org/2602983002/ > > BUG=584797 > TEST= > content_unittests --gtest_filter="*Video*", > video_capture_unittests, > Apprtc loopback on Debug, > Desktop Capture Example extension on Release > > [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing > > Review-Url: https://codereview.chromium.org/2573223002 > Cr-Commit-Position: refs/heads/master@{#442066} > Committed: https://chromium.googlesource.com/chromium/src/+/e1aac992b0399db7776661f4ac2c43094c265de7 TBR=miu@chromium.org,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584797 Review-Url: https://codereview.chromium.org/2613793007 Cr-Commit-Position: refs/heads/master@{#442130} Committed: https://chromium.googlesource.com/chromium/src/+/355fef64c80c70bf0787534f029ee84c7e58d171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+846 lines, -554 lines) Patch
M content/browser/media/capture/desktop_capture_device_aura_unittest.cc View 2 chunks +13 lines, -12 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_unittest.cc View 1 chunk +19 lines, -18 lines 0 comments Download
M content/browser/media/capture/screen_capture_device_android_unittest.cc View 1 chunk +18 lines, -17 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 6 chunks +69 lines, -24 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.h View 4 chunks +15 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 7 chunks +30 lines, -17 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 12 chunks +138 lines, -102 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_device_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc View 4 chunks +15 lines, -23 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_frame_receiver_on_io_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_frame_receiver_on_io_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/content/thread_safe_capture_oracle.h View 1 chunk +8 lines, -7 lines 0 comments Download
M media/capture/content/thread_safe_capture_oracle.cc View 5 chunks +9 lines, -10 lines 0 comments Download
M media/capture/video/fake_video_capture_device.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M media/capture/video/fake_video_capture_device_unittest.cc View 3 chunks +37 lines, -61 lines 0 comments Download
M media/capture/video/linux/v4l2_capture_delegate_unittest.cc View 3 chunks +11 lines, -9 lines 0 comments Download
M media/capture/video/shared_memory_buffer_tracker.h View 2 chunks +8 lines, -3 lines 0 comments Download
M media/capture/video/shared_memory_buffer_tracker.cc View 2 chunks +20 lines, -5 lines 0 comments Download
M media/capture/video/video_capture_buffer_handle.h View 1 chunk +7 lines, -2 lines 0 comments Download
M media/capture/video/video_capture_buffer_pool.h View 1 chunk +3 lines, -4 lines 0 comments Download
M media/capture/video/video_capture_buffer_pool_impl.h View 1 chunk +2 lines, -3 lines 0 comments Download
M media/capture/video/video_capture_buffer_pool_impl.cc View 2 chunks +13 lines, -12 lines 0 comments Download
M media/capture/video/video_capture_buffer_tracker.h View 1 chunk +3 lines, -1 line 0 comments Download
M media/capture/video/video_capture_device.h View 6 chunks +28 lines, -52 lines 0 comments Download
M media/capture/video/video_capture_device.cc View 1 chunk +4 lines, -20 lines 0 comments Download
M media/capture/video/video_capture_device_client.h View 2 chunks +28 lines, -20 lines 0 comments Download
M media/capture/video/video_capture_device_client.cc View 12 chunks +79 lines, -84 lines 0 comments Download
M media/capture/video/video_capture_device_unittest.cc View 2 chunks +14 lines, -13 lines 0 comments Download
M media/capture/video/video_capture_jpeg_decoder.h View 2 chunks +5 lines, -4 lines 0 comments Download
M media/capture/video/video_frame_receiver.h View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
A services/video_capture/buffer_tracker_factory_impl.h View 1 chunk +26 lines, -0 lines 0 comments Download
A services/video_capture/buffer_tracker_factory_impl.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M services/video_capture/device_media_to_mojo_adapter.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A services/video_capture/mojo_shared_memory_buffer_handle.h View 1 chunk +35 lines, -0 lines 0 comments Download
A services/video_capture/mojo_shared_memory_buffer_handle.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A services/video_capture/mojo_shared_memory_buffer_tracker.h View 1 chunk +37 lines, -0 lines 0 comments Download
A services/video_capture/mojo_shared_memory_buffer_tracker.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M services/video_capture/receiver_mojo_to_media_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/receiver_mojo_to_media_adapter.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
chfremer
Created Revert of [Mojo Video Capture] Simplify media::VideoCaptureDevice::Client:Buffer to a struct
3 years, 11 months ago (2017-01-07 01:04:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613793007/1
3 years, 11 months ago (2017-01-07 01:05:28 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 01:21:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/355fef64c80c70bf0787534f029e...

Powered by Google App Engine
This is Rietveld 408576698