Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2613753002: W3C import: Update manifest-updating step after upstream changes. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
tkent, jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

W3C import: Update manifest-updating step after upstream changes. Background: The recent change https://github.com/w3c/web-platform-tests/commit/758f6c45dd335e276ab822ef5d96ac31398b76e9 updated wpt-tools to include https://github.com/w3c/wpt-tools/commit/8777171a5568e9fa967ef7a807dc400d89a07637, which changed some things about the manifest format and also the way that the manifest update is done. After that change, the manifest update script looked at all files in the current repo, which in our case is the whole Chromium repo. This CL resolves this by passing the flag --work to the manifest script. BUG=678077 Committed: https://crrev.com/787a1e7a701b094d4c208820f94b3830b35515f3 Cr-Commit-Position: refs/heads/master@{#441499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -4 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
qyearsley
3 years, 11 months ago (2017-01-04 20:52:39 UTC) #4
jeffcarp
lgtm
3 years, 11 months ago (2017-01-04 22:07:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613753002/1
3 years, 11 months ago (2017-01-04 22:45:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 22:51:47 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 22:54:30 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/787a1e7a701b094d4c208820f94b3830b35515f3
Cr-Commit-Position: refs/heads/master@{#441499}

Powered by Google App Engine
This is Rietveld 408576698