Need to clear viewport dependent units switching print mode.

Need to clear viewport dependent units when switching print mode.

Switching between print and screen changes the size of the initial
containing block. Viewport dependent lengths need to be recalculated
and the cache for matched properties cleared.

Normally, notifyResizeForViewportUnits() is called from
performPreLayoutTasks when the initial containing block size changes.
That does not happen when laying out for printing and going back to
screen layout. We skip setting m_lastLayoutSize in
sendResizeEventIfNeeded. We probably do that to avoid triggering resize
events going back and forth between the print (preview) size.

Make sure we clear the matched properties cache from StyleResolver when
updating the media type.

R=mstensho@opera.com
BUG=677799
Review-Url: https://codereview.chromium.org/2613733003
Cr-Commit-Position: refs/heads/master@{#441642}
Committed: https://chromium.googlesource.com/chromium/src/+/010fc15a8b14c1d9b7a651096cdad195c2532346

[rune, 2017-01-05 10:55:22]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 10:55:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2017-01-05 10:56:04]

rune@opera.com changed reviewers:
+ jochen@chromium.org

[rune, 2017-01-05 10:56:04]

ptal

jochen for web/

[mstensho (USE GERRIT), 2017-01-05 12:04:32]

lgtm, but shouldn't the title rather be "Need to clear viewport dependent units
WHEN switching print mode."?

[rune, 2017-01-05 12:09:08]

Description was changed from

==========
Need to clear viewport dependent units switching print mode.

Switching between print and screen changes the size of the initial
containing block. Viewport dependent lengths need to be recalculated
and the cache for matched properties cleared.

Normally, notifyResizeForViewportUnits() is called from
performPreLayoutTasks when the initial containing block size changes.
That does not happen when laying out for printing and going back to
screen layout. We skip setting m_lastLayoutSize in
sendResizeEventIfNeeded. We probably do that to avoid triggering resize
events going back and forth between the print (preview) size.

Make sure we clear the matched properties cache from StyleResolver when
updating the media type.

R=mstensho@opera.com
BUG=677799
==========

to

==========
Need to clear viewport dependent units when switching print mode.

Switching between print and screen changes the size of the initial
containing block. Viewport dependent lengths need to be recalculated
and the cache for matched properties cleared.

Normally, notifyResizeForViewportUnits() is called from
performPreLayoutTasks when the initial containing block size changes.
That does not happen when laying out for printing and going back to
screen layout. We skip setting m_lastLayoutSize in
sendResizeEventIfNeeded. We probably do that to avoid triggering resize
events going back and forth between the print (preview) size.

Make sure we clear the matched properties cache from StyleResolver when
updating the media type.

R=mstensho@opera.com
BUG=677799
==========

[rune, 2017-01-05 12:09:26]

On 2017/01/05 12:04:32, mstensho wrote:
> lgtm, but shouldn't the title rather be "Need to clear viewport dependent
units
> WHEN switching print mode."?

Done.

[mstensho (USE GERRIT), 2017-01-05 12:11:08]

Also non-owner lgtm for web/

[commit-bot: I haz the power, 2017-01-05 12:27:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 12:27:24]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-01-05 12:27:36]

lgtm

[rune, 2017-01-05 12:31:00]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2017-01-05 12:31:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 12:54:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483619460682690, "parent_rev":
"5ef467b4de6356fbb252448aac57698ffd56a056", "commit_rev":
"010fc15a8b14c1d9b7a651096cdad195c2532346"}

[commit-bot: I haz the power, 2017-01-05 12:55:03]

Description was changed from

==========
Need to clear viewport dependent units when switching print mode.

Switching between print and screen changes the size of the initial
containing block. Viewport dependent lengths need to be recalculated
and the cache for matched properties cleared.

Normally, notifyResizeForViewportUnits() is called from
performPreLayoutTasks when the initial containing block size changes.
That does not happen when laying out for printing and going back to
screen layout. We skip setting m_lastLayoutSize in
sendResizeEventIfNeeded. We probably do that to avoid triggering resize
events going back and forth between the print (preview) size.

Make sure we clear the matched properties cache from StyleResolver when
updating the media type.

R=mstensho@opera.com
BUG=677799
==========

to

==========
Need to clear viewport dependent units when switching print mode.

Switching between print and screen changes the size of the initial
containing block. Viewport dependent lengths need to be recalculated
and the cache for matched properties cleared.

Normally, notifyResizeForViewportUnits() is called from
performPreLayoutTasks when the initial containing block size changes.
That does not happen when laying out for printing and going back to
screen layout. We skip setting m_lastLayoutSize in
sendResizeEventIfNeeded. We probably do that to avoid triggering resize
events going back and forth between the print (preview) size.

Make sure we clear the matched properties cache from StyleResolver when
updating the media type.

R=mstensho@opera.com
BUG=677799

Review-Url: https://codereview.chromium.org/2613733003
Cr-Commit-Position: refs/heads/master@{#441642}
Committed:
https://chromium.googlesource.com/chromium/src/+/010fc15a8b14c1d9b7a651096cda...
==========

[commit-bot: I haz the power, 2017-01-05 12:55:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/010fc15a8b14c1d9b7a651096cda...