Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2613733002: Enforce OffscreenCanvas.convertToBlob to terminate after idling for too long (Closed)

Created:
3 years, 11 months ago by xlai (Olivia)
Modified:
3 years, 11 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enforce OffscreenCanvas.convertToBlob to terminate after idling for too long BUG=657102 Review-Url: https://codereview.chromium.org/2613733002 Cr-Commit-Position: refs/heads/master@{#442059} Committed: https://chromium.googlesource.com/chromium/src/+/449b31c06863f9d26120345bdcdfb72196aeeb87

Patch Set 1 #

Patch Set 2 : test #

Total comments: 2

Patch Set 3 : rebase and fix based on junov feedback #

Messages

Total messages: 13 (9 generated)
xlai (Olivia)
OffscreenCanvas.convertToBlob() on main thread is just exactly as same as that for canvas.toBlob(). For worker ...
3 years, 11 months ago (2017-01-04 21:34:13 UTC) #2
Justin Novosad
lgtm with nit https://codereview.chromium.org/2613733002/diff/20001/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-convertToBlob-noIdleTask-worker.html File third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-convertToBlob-noIdleTask-worker.html (right): https://codereview.chromium.org/2613733002/diff/20001/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-convertToBlob-noIdleTask-worker.html#newcode17 third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-convertToBlob-noIdleTask-worker.html:17: // In WebKit Layout Tests, flag ...
3 years, 11 months ago (2017-01-06 15:49:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613733002/40001
3 years, 11 months ago (2017-01-06 21:27:07 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 21:34:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/449b31c06863f9d26120345bdcdf...

Powered by Google App Engine
This is Rietveld 408576698