Move the known CT logs to the read-only data segment

Move the known CT logs to the read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent
a const global array from being placed in the read-only
data segment. This change removes a should-be-harmless
'const' keyword to work around this quirk and move
~256 bytes to the .rdata (read-only) data segment.

VC++ bug is https://connect.microsoft.com/VisualStudio/feedback/details/3117602

BUG=677351
Review-Url: https://codereview.chromium.org/2613723005
Cr-Commit-Position: refs/heads/master@{#441804}
Committed: https://chromium.googlesource.com/chromium/src/+/90aef9d95d98c323811bc8ac8ae86570954c6d8c

[Ryan Sleevi, 2017-01-05 23:59:11]

Description was changed from

==========
Move the known CT logs to the read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent
a const global array from being placed in the read-only
data segment. This change removes a should-be-harmless
'const' keyword to work around this quirk and move
~x bytes to the .rdata (read-only) data segment.

BUG=677351
==========

to

==========
Move the known CT logs to the read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent
a const global array from being placed in the read-only
data segment. This change removes a should-be-harmless
'const' keyword to work around this quirk and move
~256 bytes to the .rdata (read-only) data segment.

VC++ bug is https://connect.microsoft.com/VisualStudio/feedback/details/3117602

BUG=677351
==========

[Ryan Sleevi, 2017-01-05 23:59:39]

rsleevi@chromium.org changed reviewers:
+ eroman@chromium.org

[Ryan Sleevi, 2017-01-05 23:59:39]

eroman: Trivial change; mostly trying to rule out memory corruption related
crashes by getting stuff into .rdata :)

[eroman, 2017-01-06 00:35:37]

lgtm

[Ryan Sleevi, 2017-01-06 00:39:01]

The CQ bit was checked by rsleevi@chromium.org

[commit-bot: I haz the power, 2017-01-06 00:40:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-01-06 01:02:27]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2017-01-06 01:02:27]

Also lgtm. Harmless, and always good to get more globals into the read-only data
section.

[commit-bot: I haz the power, 2017-01-06 01:47:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483663141054180, "parent_rev":
"5807dc6e5f6be9c395dc81b43335055f2d6a2a97", "commit_rev":
"90aef9d95d98c323811bc8ac8ae86570954c6d8c"}

[commit-bot: I haz the power, 2017-01-06 01:47:42]

Description was changed from

==========
Move the known CT logs to the read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent
a const global array from being placed in the read-only
data segment. This change removes a should-be-harmless
'const' keyword to work around this quirk and move
~256 bytes to the .rdata (read-only) data segment.

VC++ bug is https://connect.microsoft.com/VisualStudio/feedback/details/3117602

BUG=677351
==========

to

==========
Move the known CT logs to the read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent
a const global array from being placed in the read-only
data segment. This change removes a should-be-harmless
'const' keyword to work around this quirk and move
~256 bytes to the .rdata (read-only) data segment.

VC++ bug is https://connect.microsoft.com/VisualStudio/feedback/details/3117602

BUG=677351

Review-Url: https://codereview.chromium.org/2613723005
Cr-Commit-Position: refs/heads/master@{#441804}
Committed:
https://chromium.googlesource.com/chromium/src/+/90aef9d95d98c323811bc8ac8ae8...
==========

[commit-bot: I haz the power, 2017-01-06 01:47:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/90aef9d95d98c323811bc8ac8ae8...